-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Runtime Samples #490
Merged
TomAtkinsonArm
merged 9 commits into
KhronosGroup:framework/v2.0
from
TomAtkinsonArm:samples
Nov 21, 2022
Merged
Dynamic Runtime Samples #490
TomAtkinsonArm
merged 9 commits into
KhronosGroup:framework/v2.0
from
TomAtkinsonArm:samples
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAtkinsonArm
requested review from
gpx1000,
SaschaWillems,
asuessenbach,
gary-sweet and
JoseEmilio-ARM
July 8, 2022 15:21
2 tasks
Closed #488 as this PR includes its changes. Updated description |
gpx1000
approved these changes
Nov 14, 2022
TomAtkinsonArm
force-pushed
the
samples
branch
2 times, most recently
from
November 21, 2022 14:30
01f06d3
to
cfeae14
Compare
TomAtkinsonArm
force-pushed
the
samples
branch
from
November 21, 2022 14:43
cfeae14
to
d319937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a high chance that we want to reuse cross platform components in many executables.
CUSTOM_MAIN
aims to reduce duplication of a cross platform main.Adds
sample_main(context)
. Works similar to a normalmain
function except it hides the cross platform support.The minimum code needed for a sample is
Later a Sample Launcher will read library paths and sample info from a JSON file. Allow the user to select a sample to run and then run the sample by loading the dynamic library and calling
sample_main
. We can extend this to allow for CLI configuration and more.