Implicitly enable EXT_float_blend and promote it to Community Approved. #2830
Conversation
|
This is going to get us into the same situation we got into with float rendering where apps will rely on the implicit enabling and then fail on platforms where this the feature is no available. In this case, that is every mobile platforms. Why are we doing this? Since it is easy to update web applications why are we so keen not to break apps. They'll break anyway when run on mobile. We should force the authors to fix them by not implicitly enabling. |
|
We can't update apps that are no longer maintained, so we do this dance where we enable it implicitly, but should warn in the console when it's used implicitly, and use that to convince authors to improve the portability of their content. |
|
@kenrussell PTAL |
| @@ -29,7 +29,9 @@ void main() | |||
| } | |||
| `; | |||
|
|
|||
| function testExtFloatBlend(shouldBlend, internalFormat) { | |||
| function testExtFloatBlend(internalFormat) { | |||
| const shouldBlend = gl.getSupportedExtensions().indexOf('EXT_float_blend') != -1; | |||
There was a problem hiding this comment.
These mean the browser MUST expose EXT_float_blend if it supports float blend, right?
There was a problem hiding this comment.
That's very strict, but it is nice. Seems ok with me.
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <draft href="EXT_float_blend/"> | |||
| <extension href="EXT_float_blend/"> | |||
There was a problem hiding this comment.
Shouldn't there be a public_webgl post about this first?
There was a problem hiding this comment.
I can post about it, but I don't think there's an ordering requirement.
| @@ -29,7 +29,9 @@ void main() | |||
| } | |||
| `; | |||
|
|
|||
| function testExtFloatBlend(shouldBlend, internalFormat) { | |||
| function testExtFloatBlend(internalFormat) { | |||
| const shouldBlend = gl.getSupportedExtensions().indexOf('EXT_float_blend') != -1; | |||
Update tests to require implicit activation accordingly.
kdashg
force-pushed
the
promote-ext-float-blend
branch
from
585f452
to
1f94520
Compare
|
Thanks! |
Prevented building of the extension registry. Follow-up to KhronosGroup#2830.
Prevented building of the extension registry. Follow-up to #2830.
Update tests to require implicit activation accordingly.