Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

CI to validate models #26

Closed
pjcozzi opened this issue Jan 21, 2017 · 12 comments
Closed

CI to validate models #26

pjcozzi opened this issue Jan 21, 2017 · 12 comments

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Jan 21, 2017

It would be super cool to setup CI that

Contributions here are very welcome!

@lexaknyazev
Copy link
Member

I've opened a meta-issue in Validator repo to track this. Will do integration stuff from Validator's side.

@kyasbal
Copy link

kyasbal commented Feb 24, 2017

And if there was zip task to compress each models to download easily, it is great.
I don't want to download whole zip or clone all models when I just want to test a model file.

@donmccurdy
Copy link
Contributor

donmccurdy commented Mar 8, 2017

@kyasbal-1994 it would be nice to have something more obvious/discoverable, but you can download individual model directories using this tool: http://kinolien.github.io/gitzip/

@lexaknyazev
Copy link
Member

@Khronoswebmaster
Could you enable Travis for this repo?

@outofcontrol
Copy link

Enabled. Do you need Appveyor as well?

@lexaknyazev
Copy link
Member

Just enabled CI validation for 2.0 models.

@pjcozzi
Copy link
Member Author

pjcozzi commented May 24, 2017

Do you need Appveyor as well?

Not for this repo.

@emackey
Copy link
Member

emackey commented May 24, 2017

Has this CI already run on the master branch? Is there a link to the results?

@lexaknyazev
Copy link
Member

It runs on making a commit or opening PR to master.

Some models contain errors, so CI build is failing.

https://travis-ci.org/KhronosGroup/glTF-Sample-Models

We should add a badge with status to repo's readme.

@lexaknyazev
Copy link
Member

Badge added.

@pjcozzi
Copy link
Member Author

pjcozzi commented Dec 13, 2017

Use popular WebGL engines to preview them like @cx20's gltf-test. This could be great to find issues in the models and engines.

See KhronosGroup/glTF#1081 (comment)

@emackey
Copy link
Member

emackey commented Jul 19, 2021

This was added some time ago. The results are visible in the GitHub Actions tab.

@emackey emackey closed this as completed Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants