Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample model syntax fix #770

Closed
wants to merge 1 commit into from

Conversation

yucombinator
Copy link
Contributor

I noticed that the .glb sample model for BrainStem has an extra field ("disable":[]) in techniques.states, causing it to fail schema validation.

I don't think that field is defined anywhere in official specs (only enable is defined in v1.0), so I edited the glb file and removed it, as it was not needed anyways. The disable field is absent from other versions of the model (gltf, gltf-embedded, etc).

@pjcozzi
Copy link
Member

pjcozzi commented Nov 10, 2016

Good catch! disable was removed from the spec before it was finalized.

@lexaknyazev should we re-open this PR in glTF-Sample-Models since that is the future home of the sample models?

@lexaknyazev
Copy link
Member

This error was introduced with 9d97cfc.
CC @lasalvavida

Since we're going to remove all models from this repo, PR should go straight to glTF-Sample-Models.

@nehmebilal
Copy link

I'm curious, why not remove the sample models from this repo right away and provide a link to the new repo to avoid confusion and potentially diverging models?

@lexaknyazev
Copy link
Member

I'm curious, why not remove the sample models from this repo right away and provide a link to the new repo to avoid confusion and potentially diverging models?

@nehmebilal
It'll happen very-very soon (1-2 days).

@pjcozzi
Copy link
Member

pjcozzi commented Nov 13, 2016

@lasalvavida could you look at this soon? It would help us with glTF 1.1.

@lexaknyazev
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants