Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failing with GCC13 on master commit #3139

Closed
DeadSix27 opened this issue Feb 16, 2023 · 3 comments · Fixed by #3144
Closed

Build failing with GCC13 on master commit #3139

DeadSix27 opened this issue Feb 16, 2023 · 3 comments · Fixed by #3144
Assignees
@arcady-lunarg

Comments

@DeadSix27
Copy link

glslang/glslang/MachineIndependent/SymbolTable.h:70:1: note: 'uint32_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

Somewhere it forgets to include cstdint, I'm using latest MinGW commit and GCC13.0.1
@arcady-lunarg arcady-lunarg self-assigned this Feb 20, 2023
arcady-lunarg added a commit to arcady-lunarg/glslang that referenced this issue Feb 21, 2023
@arcady-lunarg
Include <cstdint> header in Common.h
eccfe39 
This change also cleans up some ifdef'd code for no longer supported
versions of MSVC.

Fixes: KhronosGroup#3139
@arcady-lunarg arcady-lunarg mentioned this issue Feb 21, 2023
Merged
@JohannesKauffmann
Copy link
Contributor

This is not MinGW specific, but GCC 13. See https://gcc.gnu.org/gcc-13/porting_to.html.

@DeadSix27
Copy link
Author

This is not MinGW specific, but GCC 13. See https://gcc.gnu.org/gcc-13/porting_to.html.

Ah thanks for clarifying, makes sense.

@DeadSix27 DeadSix27 changed the title MinGW build failing on latest master commit Build failing with GCC13 on master commit Feb 27, 2023
@diegocr diegocr mentioned this issue May 8, 2023
Closed
@hydra3333
Copy link

Hi.

Just a gentle prompt to please apply the patch asap.

Without it some mingw based builds systems, including MABS, cannot build your product ... which is a great deal less than ideal :)

@hydra3333 hydra3333 mentioned this issue May 13, 2023
Closed
arcady-lunarg added a commit to arcady-lunarg/glslang that referenced this issue May 15, 2023
@arcady-lunarg
Include <cstdint> header in Common.h
aea6dec 
This change also cleans up some ifdef'd code for no longer supported
versions of MSVC.

Fixes: KhronosGroup#3139
arcady-lunarg added a commit to arcady-lunarg/glslang that referenced this issue May 15, 2023
@arcady-lunarg
Include <cstdint> header in Common.h
0278743 
This change also cleans up some ifdef'd code for no longer supported
versions of MSVC.

Fixes: KhronosGroup#3139
arcady-lunarg added a commit that referenced this issue May 15, 2023
@arcady-lunarg
Include <cstdint> header in Common.h
1e4955a 
This change also cleans up some ifdef'd code for no longer supported
versions of MSVC.

Fixes: #3139
hansemro added a commit to hansemro/scopehal-docs that referenced this issue Dec 2, 2023
@hansemro
ng-gettingstarted: bump Vulkan SDK to 1.3.268 for Windows
4887164 
This addresses a glslang build issue on 1.3.224 with GCC 13 (not
specific to MINGW) due to missing cstdint include. Bump to a more
recent (and tested) SDK in doc to resolve glslang build issue.

KhronosGroup/glslang#3139
hansemro added a commit to hansemro/scopehal-docs that referenced this issue Dec 2, 2023
@hansemro
ng-gettingstarted: bump Vulkan SDK to 1.3.268 for Windows
6d24b7a 
This addresses a glslang build issue on 1.3.224 with GCC 13 (not
specific to MINGW) due to missing cstdint include. Bump to a more
recent (and tested) SDK in doc to resolve glslang build issue.

Reference: KhronosGroup/glslang#3139
@hansemro hansemro mentioned this issue Dec 2, 2023
Merged
kd-11 pushed a commit to kd-11/glslang that referenced this issue Dec 11, 2023
@arcady-lunarg @kd-11
Include <cstdint> header in Common.h
6ae905e 
This change also cleans up some ifdef'd code for no longer supported
versions of MSVC.

Fixes: KhronosGroup#3139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arcady-lunarg arcady-lunarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include <cstdint> header in Common.h arcady-lunarg/glslang
4 participants
@DeadSix27 @hydra3333 @JohannesKauffmann @arcady-lunarg