Sort order of channels #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der, according to their sorting indices and names
|
Sorry for the later reply, I just found the mail in my spam folder. :) Thank you very much for your contribution! |
Kissaki
added a commit
that referenced
this pull request
Jun 5, 2011
Sort order of channels (channel viewer protocol provider)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, Channels were displayed in the Mumble viewer without any sorting. This commit adds some code to ChannelViewerProtocolProducer to change that.
I am not quite sure whether this is the right place to sort the channels. Maybe you want to change it in MView.js instead, but I think returning the channels in their correct order also makes sense on the server side. Plus, it's probably more work to do the sorting in Javascript ;)