-
-
Notifications
You must be signed in to change notification settings - Fork 598
[WIP] Upgrade to PHP 7 #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I like this.
Did you do these manually or did you just a script/tool? Which one?
Also, check the test code, we cannot simply just remove annotations like that.
|
||
/** | ||
* @test | ||
* @expectedException \Github\Exception\MissingArgumentException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These annotations cannot just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I got one broken Sniff that causes this.
Will fix, thannks
Why not bump to minumum php 7.1? 7.0 will "lose" it's active support in 18 days (http://php.net/supported-versions.php) I will try to do a full review in the next few days! |
} | ||
|
||
/* | ||
* Add user to organization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also broken sniff/fixer.
Will fix it, thanks
Replaced by #651 with passing tests and fixed coding style |
Why?
This package would be still available for PHP 5.6-.
What do you think?