-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log) logs the authenticated consumer #2367
Conversation
b5dced6
to
d608146
Compare
Maybe some tests? with auth that has a consumer as well as with auth that doesn't have a consumer (like ldap) |
I would expect the consumer to be |
I would expect that to, but a test would be the prove of that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those tests are fine for now, but ideally crucially lack integration tests, ensuring that we are correctly setting ngx.ctx.authenticated_consumer
. This is especially important in such dynamic languages that are so vulnerable to typos, as proven times and times again. Will squash and merge.
Full changelog