Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log) logs the authenticated consumer #2367

Merged
merged 5 commits into from
Apr 11, 2017
Merged

Conversation

subnetmarco
Copy link
Member

Full changelog

  • Logging plugins now also log the authenticated consumer

@Tieske
Copy link
Member

Tieske commented Apr 10, 2017

Maybe some tests? with auth that has a consumer as well as with auth that doesn't have a consumer (like ldap)

@subnetmarco
Copy link
Member Author

subnetmarco commented Apr 10, 2017

with auth that has a consumer as well as with auth that doesn't have a consumer (like ldap)

I would expect the consumer to be nil, and therefore the property to be missing (like it happens one line above with the API object for example).

@Tieske
Copy link
Member

Tieske commented Apr 10, 2017

I would expect that to, but a test would be the prove of that.

Copy link
Member

@thibaultcha thibaultcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those tests are fine for now, but ideally crucially lack integration tests, ensuring that we are correctly setting ngx.ctx.authenticated_consumer. This is especially important in such dynamic languages that are so vulnerable to typos, as proven times and times again. Will squash and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants