Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datadog) new metrics and more flexible configuration #2394

Merged
merged 1 commit into from
Jun 22, 2017
Merged

feat(datadog) new metrics and more flexible configuration #2394

merged 1 commit into from
Jun 22, 2017

Conversation

shashiranjan84
Copy link
Contributor

@shashiranjan84 shashiranjan84 commented Apr 14, 2017 •
edited
Loading

Summary

  • Now each metric supports configurable stat type,
    sample rate and customer identifier if applicable.
  • Custom prefix for stats's name
  • Custom tags for Datadog.
  • New metrics upstream_latency, kong_latency and status_count_per_user.

Full changelog

  • Schema updated to support new metrics
  • Schema updated to support stat_type, sample_rate, consumer_identifier, and tags
  • Added new schema checks and test

Issues resolved

NOTE: depends on the PR on #2367

@p0pr0ck5
Copy link
Contributor

p0pr0ck5 commented Apr 17, 2017 •
edited
Loading

Seems like one failed test related to this PR? the lambda tests are unrelated (this likely just needs to be rebased)

@shashiranjan84
Copy link
Contributor Author

@p0pr0ck5 test will fail because this PR depends on PR on #2367. SO basically next needs to be synced with master

@p0pr0ck5
Copy link
Contributor

Looks like master was merged into next a few days ago in efb6612? I think if you rebase both these against next you should be good.

@shashiranjan84
Copy link
Contributor Author

@p0pr0ck5 done.

@shashiranjan84 shashiranjan84 mentioned this pull request Apr 18, 2017
Closed
@shashiranjan84 shashiranjan84 force-pushed the feat/configurable-datadog branch from 77f6edc to 74e4ac6 Compare April 18, 2017 00:46
@p0pr0ck5 p0pr0ck5 mentioned this pull request Apr 18, 2017
Closed
Tieske
Tieske previously requested changes May 1, 2017
View reviewed changes
Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comments on statsd apply here as well.

@shashiranjan84 shashiranjan84 force-pushed the feat/configurable-datadog branch from 74e4ac6 to 294fbf5 Compare May 1, 2017 18:18
@thibaultcha thibaultcha added this to the 0.11.0 milestone May 19, 2017
@shashiranjan84 shashiranjan84 force-pushed the feat/configurable-datadog branch 6 times, most recently from d043e2a to cd1864d Compare June 6, 2017 21:58
@shashiranjan84 shashiranjan84 changed the title feat(plugins/datadog) new metrics and more flexible configuration feat(datadog) new metrics and more flexible configuration Jun 7, 2017
@shashiranjan84 shashiranjan84 force-pushed the feat/configurable-datadog branch 5 times, most recently from f0dfb27 to 3846440 Compare June 13, 2017 04:00
@p0pr0ck5 p0pr0ck5 added pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done. and removed pr/status/please review labels Jun 21, 2017
@p0pr0ck5
Copy link
Contributor

Same comments from statsd: #2400 (comment)

@shashiranjan84 shashiranjan84 force-pushed the feat/configurable-datadog branch from 3846440 to 7aca1c2 Compare June 21, 2017 23:11
@shashiranjan84 shashiranjan84 added pr/status/please review and removed pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done. labels Jun 21, 2017
@shashiranjan84
Copy link
Contributor Author

shashiranjan84 commented Jun 21, 2017 •
edited
Loading

@Tieske would you please also review this and PR #2400?

@shashiranjan84 shashiranjan84 force-pushed the feat/configurable-datadog branch 2 times, most recently from 177cb32 to 3687a4b Compare June 22, 2017 19:10
p0pr0ck5
p0pr0ck5 previously approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@p0pr0ck5 p0pr0ck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as applies to the other review

feat(datadog) new metrics and more flexible configuration
44b446c 
- Now each metric supports configurable stat type,
  sample rate and customer identifier if applicable.
- Custom prefix for stats's name
- Custom tags for Datadog.
- New metrics `upstream_latency`, `kong_latency` and `status_count_per_user`.
- Code style format
@shashiranjan84 shashiranjan84 force-pushed the feat/configurable-datadog branch from 3687a4b to 44b446c Compare June 22, 2017 22:57
@shashiranjan84 shashiranjan84 dismissed Tieske’s stale review June 22, 2017 23:04

added his advised changes

@shashiranjan84 shashiranjan84 added the pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) label Jun 22, 2017
@shashiranjan84 shashiranjan84 merged commit c92d2d1 into next Jun 22, 2017
@thibaultcha thibaultcha deleted the feat/configurable-datadog branch October 27, 2017 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0pr0ck5 p0pr0ck5 p0pr0ck5 approved these changes

@Tieske Tieske Tieske left review comments

Assignees

@shashiranjan84 shashiranjan84

Labels
pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shashiranjan84 @p0pr0ck5 @Tieske @thibaultcha