Feat/prometheus #3547
Closed
Feat/prometheus #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
added
pr/wip
Prometheus plugin needs a dedicated shm to store metrics of Kong and it's upstream. This patch sets the injects the requried shm into NGINX template if the plugin is available for use. The size chosen for the shm is 5 MB, which is more than sufficient to store metrics related to a few hundred services (tested for upto 200 services). This is a temporary workaround until there is an API exposed from the core which allows specifying custom shared dicts for plugin. When such an API is introduced, the changes introduced by commit should be reverted.
hbagdi
removed
pr/do not merge
pr/wip
thibaultcha
reviewed
Jun 15, 2018
|
|
||
| if shm_value then | ||
| if not string.match(shm_value, "prometheus_metrics") then | ||
| shm_value = shm_value .. "; lua_shared_dict prometheus_metrics 5m" |
There was a problem hiding this comment.
This is making me regret that the loop injected in the template is not iterating over an array, which would be future proof, would not make this hack necessary, and would yield predictable results if we ever do or allow some sorting of the directives...
There was a problem hiding this comment.
I see, good point since this the directive injection can be used as frequent internally in the code as an end user would want to do it via kong.conf.
thibaultcha
pushed a commit
that referenced
this pull request
Jun 16, 2018
Plugin source code located at: https://github.com/Kong/kong-plugin-prometheus From #3547
thibaultcha
pushed a commit
that referenced
this pull request
Jun 16, 2018
Prometheus plugin needs a dedicated shm to store metrics of Kong and it's upstream. This patch sets the injects the requried shm into NGINX template if the plugin is available for use. The size chosen for the shm is 5 MB, which is more than sufficient to store metrics related to a few hundred services (tested for upto 200 services). This is a temporary workaround until there is an API exposed from the core which allows specifying custom shared dicts for plugin. When such an API is introduced, the changes introduced by commit should be reverted. From #3547
|
Merged! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.