include JsonFacadeForDebugger in compilation #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
reviewed
Sep 10, 2025
|
|
||
| sourceSets { | ||
| main { | ||
| java.srcDirs("src/main/kotlin") |
There was a problem hiding this comment.
wait, this works? In the past I could've sworn java had something hardcoded somewhere that .java files needed to be in a 'java' folder. For Kotlin this wasn't a constraint, so mixed projects would use the 'java' directory. This is still the case on Android.
There was a problem hiding this comment.
On android indeed :) But apparently it does, for example in Kotlin repo they don't even have src/main/kotlin, only src/ for main sources and test/ or testFixtures/ etc for tests, with both java and kotlin files
Jolanrensen
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it wasn't in the jar because java didn't see the file in Kotlin source set; i changed java to point in the same directory because separate source sets for different languages is an outdated and bad practice :)
