Skip to content

include JsonFacadeForDebugger in compilation #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

include JsonFacadeForDebugger in compilation #1439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dataframe-json/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ tasks.test {
useJUnitPlatform()
}

sourceSets {
main {
java.srcDirs("src/main/kotlin")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, this works? In the past I could've sworn java had something hardcoded somewhere that .java files needed to be in a 'java' folder. For Kotlin this wasn't a constraint, so mixed projects would use the 'java' directory. This is still the case on Android.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On android indeed :) But apparently it does, for example in Kotlin repo they don't even have src/main/kotlin, only src/ for main sources and test/ or testFixtures/ etc for tests, with both java and kotlin files

}
}

val instrumentedJars: Configuration by configurations.creating {
isCanBeConsumed = true
isCanBeResolved = false
Expand Down