add kwarg legend and change kwarg label
#15
Conversation
There was a problem hiding this comment.
I didn't know there was a \labeldirective that you could attach to plots. The current naming of the keyword is thus unfortunate indeed.
What I don't like about this is that it will silently change peoples plots without any deprecation. I'm not sure what the best deprecation strategy is, but I think there needs to be some heads up to users.
| @@ -13,12 +14,14 @@ end | |||
| Base.push!(plot::Plot, element) = (push!(plot.elements, element); plot) | |||
| Base.append!(plot::Plot, element) = (append!(plot.elements, element); plot) | |||
|
|
|||
| function Plot(elements::AbstractVector, args::Vararg{PGFOption}; incremental = true, label = nothing) | |||
| Plot(elements, dictify(args), label, incremental, false) | |||
| function Plot(elements::AbstractVector, args::Vararg{PGFOption}; incremental = | |||
There was a problem hiding this comment.
This line breaking seems odd to me.
There was a problem hiding this comment.
I take advantage of Julia's flexibility with newlines. I hard-wrap at 80 characters. It's definitely a bad line break. Feel free to change it.
|
Yeah, I have an idea to fix everything. If someone provides both the |
Filed an issue regarding this, already.