feat: impl query tools. #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
added
enhancement
Peefy
force-pushed
the
dev/peefy/feat_query_tool
branch
5 times, most recently
from
d45e80e to
055aca3
Compare
ldxdl
reviewed
May 31, 2022
ldxdl
reviewed
May 31, 2022
ldxdl
reviewed
May 31, 2022
ldxdl
reviewed
May 31, 2022
ldxdl
reviewed
Jun 7, 2022
ldxdl
reviewed
Jun 7, 2022
ldxdl
reviewed
Jun 7, 2022
ldxdl
reviewed
Jun 7, 2022
Peefy
force-pushed
the
dev/peefy/feat_query_tool
branch
from
810627d to
6afc7db
Compare
ldxdl
reviewed
Jun 9, 2022
ldxdl
reviewed
Jun 9, 2022
ldxdl
reviewed
Jun 9, 2022
ldxdl
reviewed
Jun 9, 2022
Peefy
force-pushed
the
dev/peefy/feat_query_tool
branch
from
6afc7db to
b60c9d3
Compare
ldxdl
reviewed
Jun 15, 2022
ldxdl
reviewed
Jun 15, 2022
ldxdl
reviewed
Jun 15, 2022
Peefy
force-pushed
the
dev/peefy/feat_query_tool
branch
3 times, most recently
from
658beab to
4e1ea53
Compare
chai2010
reviewed
Jun 16, 2022
Peefy
force-pushed
the
dev/peefy/feat_query_tool
branch
from
4e1ea53 to
0fb03bd
Compare
zong-zhe
previously approved these changes
Jun 20, 2022
chai2010
previously approved these changes
Jun 28, 2022
Peefy
force-pushed
the
dev/peefy/feat_query_tool
branch
2 times, most recently
from
70c4da5 to
4dfc986
Compare
Peefy
force-pushed
the
dev/peefy/feat_query_tool
branch
from
4dfc986 to
d4bda14
Compare
chai2010
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the scope of this change (e.g. component or file name):
kclvm/tools/src/query/mod.rs,
kclvm/tools/src/query/override.rs
kclvm/tools/src/query/tests.rs
Provide a description of the change(e.g. more details, motivations or doc link):
KCL Rust version of the query tool, and provides query APIs to further build tools such as the query CLI.
The main API function involved is
override_file, the user can specify the file to be modified and the modification specification through this function. The specification mainly includes the path and modification value of the configuration to be modified.Does this change affect any open issues?(Y/N) and add issue references
Y, #54
Tests
Unit Tests
Test cases in kclvm/tools/src/query/tests.rs
Benchmark
Test cases in kclvm/tools/benches/benchmark.rs
The
override_fileapi benchmark result as follows: