Skip to content

Conversation

@amyXia1994
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

fix #20

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/swagger/generator/types.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The test case in pkg/kube_resource/generator/testdata/union_type is used to test the k8s int or str type flag

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support resolving x-kubernetes-int-or-string extension to KCL int | str type

@amyXia1994 amyXia1994 requested a review from chai2010 July 22, 2022 10:09
Peefy
Peefy previously approved these changes Aug 9, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Aug 17, 2022

Pull Request Test Coverage Report for Build 2880765914

  • 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 66.782%

Totals Coverage Status
Change from base Build 2880741343: 0.2%
Covered Lines: 1938
Relevant Lines: 2902

💛 - Coveralls

@amyXia1994 amyXia1994 force-pushed the dev/xiarui.xr/int-or-str branch from 1ee4b24 to 15ef155 Compare August 17, 2022 11:58
chai2010
chai2010 previously approved these changes Aug 18, 2022
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyXia1994 amyXia1994 merged commit 96af9c1 into kcl-lang:main Aug 18, 2022
@amyXia1994 amyXia1994 deleted the dev/xiarui.xr/int-or-str branch August 18, 2022 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the intOrString types in k8s crd is treated as the first type in generation

4 participants