New loading screen component #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojopirker
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
AbdBarho
reviewed
Dec 29, 2022
| @@ -8,6 +8,7 @@ import poster from "src/lib/poster"; | |||
| import { Messages } from "src/components/Messages"; | |||
| import { TwoColumns } from "src/components/TwoColumns"; | |||
| import { Button } from "src/components/Button"; | |||
| import { LoadingScreen } from "@/components/Loading/LoadingScreen"; | |||
There was a problem hiding this comment.
please use src instead of @
There was a problem hiding this comment.
I think it's fine if vs code is doing it. I'm going to delete this mapping from tsconfig soon so it stops happening.
There was a problem hiding this comment.
I agree, let's merge in the storybook change and then this. I'll approve after #110 goes in.
| }, | ||
| }; | ||
|
|
||
| const Template = (args) => <LoadingScreen {...args} />; //<><div>text</div><div className="max-w-500 mt-40 z-1000 h-full relative"></div></>; |
There was a problem hiding this comment.
the commented out div can probably be deleted
| @@ -8,6 +8,7 @@ import poster from "src/lib/poster"; | |||
| import { Messages } from "src/components/Messages"; | |||
| import { TwoColumns } from "src/components/TwoColumns"; | |||
| import { Button } from "src/components/Button"; | |||
| import { LoadingScreen } from "@/components/Loading/LoadingScreen"; | |||
There was a problem hiding this comment.
I think it's fine if vs code is doing it. I'm going to delete this mapping from tsconfig soon so it stops happening.
AbdBarho
approved these changes
Dec 29, 2022
fozziethebeat
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of a new loading screen component as mentionend in #103. I also replaced the
if (tasks.length == 0)with theisLoadingfromuseSWRImmutable. Also includes a story for storybook, which showcases usage with and without text.