Static Code Analysis with Php Inspections (EA Extended)

lib/addon/sfPager.class.php

@@ -380,7 +380,7 @@ public function getPreviousPage()
    */
   public function setPage($page)
   {
-    $this->page = intval($page);
+    $this->page = (int) $page;
 
     if ($this->page <= 0)
     {

lib/cache/sfFileCache.class.php

@@ -83,7 +83,7 @@ public function has($key)
    */
   public function set($key, $data, $lifetime = null)
   {
-    if ($this->getOption('automatic_cleaning_factor') > 0 && rand(1, $this->getOption('automatic_cleaning_factor')) == 1)
+    if ($this->getOption('automatic_cleaning_factor') > 0 && mt_rand(1, $this->getOption('automatic_cleaning_factor')) == 1)
     {
       $this->clean(sfCache::OLD);
     }
@@ -235,12 +235,12 @@ protected function read($path, $type = self::READ_DATA)
     }
 
     @flock($fp, LOCK_SH);
-    $data[self::READ_TIMEOUT] = intval(@stream_get_contents($fp, 12, 0));
+    $data[self::READ_TIMEOUT] = (int) @stream_get_contents($fp, 12, 0);
     if ($type != self::READ_TIMEOUT && time() < $data[self::READ_TIMEOUT])
     {
       if ($type & self::READ_LAST_MODIFIED)
       {
-        $data[self::READ_LAST_MODIFIED] = intval(@stream_get_contents($fp, 12, 12));
+        $data[self::READ_LAST_MODIFIED] = (int) @stream_get_contents($fp, 12, 12);
       }
       if ($type & self::READ_DATA)
       {

lib/cache/sfMemcacheCache.class.php

@@ -3,7 +3,7 @@
 /*
  * This file is part of the symfony package.
  * (c) 2004-2006 Fabien Potencier <fabien.potencier@symfony-project.com>
- * 
+ *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
@@ -60,7 +60,7 @@ public function initialize($options = array())
         foreach ($this->getOption('servers') as $server)
         {
           $port = isset($server['port']) ? $server['port'] : 11211;
-          if (!$this->memcache->addServer($server['host'], $port, isset($server['persistent']) ? $server['persistent'] : true))
+          if (!$this->memcache->addserver($server['host'], $port, isset($server['persistent']) ? $server['persistent'] : true))
           {
             throw new sfInitializationException(sprintf('Unable to connect to the memcache server (%s:%s).', $server['host'], $port));
           }

lib/cache/sfSQLiteCache.class.php

@@ -94,7 +94,7 @@ public function has($key)
    */
   public function set($key, $data, $lifetime = null)
   {
-    if ($this->getOption('automatic_cleaning_factor') > 0 && rand(1, $this->getOption('automatic_cleaning_factor')) == 1)
+    if ($this->getOption('automatic_cleaning_factor') > 0 && mt_rand(1, $this->getOption('automatic_cleaning_factor')) == 1)
     {
       $this->clean(sfCache::OLD);
     }
@@ -167,7 +167,7 @@ public function getTimeout($key)
 
     $rs = $this->dbh->query(sprintf("SELECT timeout FROM cache WHERE key = '%s' AND timeout > %d", sqlite_escape_string($key), time()));
 
-    return $rs->numRows() ? intval($rs->fetchSingle()) : 0;
+    return $rs->numRows() ? (int) $rs->fetchSingle() : 0;
   }
 
   /**
@@ -184,7 +184,7 @@ public function getLastModified($key)
 
     $rs = $this->dbh->query(sprintf("SELECT last_modified FROM cache WHERE key = '%s' AND timeout > %d", sqlite_escape_string($key), time()));
 
-    return $rs->numRows() ? intval($rs->fetchSingle()) : 0;
+    return $rs->numRows() ? (int) $rs->fetchSingle() : 0;
   }
 
   /**

lib/config/sfAutoloadConfigHandler.class.php

@@ -160,7 +160,7 @@ static public function getConfiguration(array $configFiles)
     foreach ($configFiles as $i => $configFile)
     {
       $configFilePath = str_replace(DIRECTORY_SEPARATOR, '/', $configFile);
-      $path = str_replace(DIRECTORY_SEPARATOR, '/', realpath(join('/', array_slice(explode('/', $configFilePath), 0, -2))));
+      $path = str_replace(DIRECTORY_SEPARATOR, '/', realpath(implode('/', array_slice(explode('/', $configFilePath), 0, -2))));
       if (in_array($path, $pluginPaths))
       {
         $pluginConfigFiles[] = $configFile;

lib/config/sfPluginConfiguration.class.php

@@ -3,14 +3,14 @@
 /*
  * This file is part of the symfony package.
  * (c) Fabien Potencier <fabien.potencier@symfony-project.com>
- * 
+ *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
 
 /**
  * sfPluginConfiguration represents a configuration for a symfony plugin.
- * 
+ *
  * @package    symfony
  * @subpackage config
  * @author     Kris Wallsmith <kris.wallsmith@symfony-project.com>
@@ -26,7 +26,7 @@ abstract class sfPluginConfiguration
 
   /**
    * Constructor.
-   * 
+   *
    * @param sfProjectConfiguration $configuration The project configuration
    * @param string                 $rootDir       The plugin root directory
    * @param string                 $name          The plugin name
@@ -50,7 +50,7 @@ public function __construct(sfProjectConfiguration $configuration, $rootDir = nu
 
   /**
    * Sets up the plugin.
-   * 
+   *
    * This method can be used when creating a base plugin configuration class for other plugins to extend.
    */
   public function setup()
@@ -59,7 +59,7 @@ public function setup()
 
   /**
    * Configures the plugin.
-   * 
+   *
    * This method is called before the plugin's classes have been added to sfAutoload.
    */
   public function configure()
@@ -68,9 +68,9 @@ public function configure()
 
   /**
    * Initializes the plugin.
-   * 
+   *
    * This method is called after the plugin's classes have been added to sfAutoload.
-   * 
+   *
    * @return boolean|null If false sfApplicationConfiguration will look for a config.php (maintains BC with symfony < 1.2)
    */
   public function initialize()
@@ -79,7 +79,7 @@ public function initialize()
 
   /**
    * Returns the plugin root directory.
-   * 
+   *
    * @return string
    */
   public function getRootDir()
@@ -89,7 +89,7 @@ public function getRootDir()
 
   /**
    * Returns the plugin name.
-   * 
+   *
    * @return string
    */
   public function getName()
@@ -99,11 +99,11 @@ public function getName()
 
   /**
    * Initializes autoloading for the plugin.
-   * 
+   *
    * This method is called when a plugin is initialized in a project
    * configuration. Otherwise, autoload is handled in
    * {@link sfApplicationConfiguration} using {@link sfAutoload}.
-   * 
+   *
    * @see sfSimpleAutoload
    */
   public function initializeAutoload()
@@ -126,10 +126,10 @@ public function initializeAutoload()
 
   /**
    * Filters sfAutoload configuration values.
-   * 
-   * @param sfEvent $event  
-   * @param array   $config 
-   * 
+   *
+   * @param sfEvent $event
+   * @param array   $config
+   *
    * @return array
    */
   public function filterAutoloadConfig(sfEvent $event, array $config)
@@ -169,10 +169,10 @@ public function connectTests()
 
   /**
    * Listens for the "task.test.filter_test_files" event and adds tests from the current plugin.
-   * 
+   *
    * @param  sfEvent $event
    * @param  array   $files
-   * 
+   *
    * @return array An array of files with the appropriate tests from the current plugin merged in
    */
   public function filterTestFiles(sfEvent $event, $files)
@@ -211,18 +211,18 @@ public function filterTestFiles(sfEvent $event, $files)
 
   /**
    * Guesses the plugin root directory.
-   * 
+   *
    * @return string
    */
   protected function guessRootDir()
   {
     $r = new ReflectionClass(get_class($this));
-    return realpath(dirname($r->getFilename()).'/..');
+    return realpath(dirname($r->getFileName()).'/..');
   }
 
   /**
    * Guesses the plugin name.
-   * 
+   *
    * @return string
    */
   protected function guessName()

lib/config/sfRootConfigHandler.class.php

@@ -35,7 +35,7 @@ public function execute($configFiles)
     $config = static::getConfiguration($configFiles);
 
     // determine if we're loading the system config_handlers.yml or a module config_handlers.yml
-    $moduleLevel = ($this->getParameterHolder()->get('module_level') === true) ? true : false;
+    $moduleLevel = ($this->getParameterHolder()->get('module_level') === true);
 
     if ($moduleLevel)
     {

lib/config/sfRoutingConfigHandler.class.php

@@ -95,7 +95,7 @@ protected function parse($configFiles)
       else
       {
         $routes[$name] = array(isset($params['class']) ? $params['class'] : 'sfRoute', array(
-          $params['url'] ? $params['url'] : '/',
+          $params['url'] ?: '/',
           isset($params['params']) ? $params['params'] : (isset($params['param']) ? $params['param'] : array()),
           isset($params['requirements']) ? $params['requirements'] : array(),
           isset($params['options']) ? $params['options'] : array(),

lib/debug/sfWebDebug.class.php

@@ -207,7 +207,7 @@ public function asHtml()
           $titles[] = sprintf('<li%s><a title="%s" href="%s"%s>%s</a></li>',
             $panel->getStatus() ? ' class="sfWebDebug'.ucfirst($this->getPriority($panel->getStatus())).'"' : '',
             $panel->getPanelTitle(),
-            $panel->getTitleUrl() ? $panel->getTitleUrl() : '#',
+            $panel->getTitleUrl() ?: '#',
             $panel->getTitleUrl() ? '' : ' onclick="sfWebDebugShowDetailsFor(\''.$id.'\'); return false;"',
             $title
           );