Rewrite the pen line shader to be more numerically stable #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwillisf
approved these changes
May 13, 2020
Contributor
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
LGTM! Let's try to get this in for next week since there's so much scratch-render stuff already in this week's test session :)
Contributor
|
Hold off on merging until after this week's deploy |
HATE. LET ME TELL YOU HOW MUCH I'VE COME TO HATE GLSL FLOATS SINCE I BEGAN TO LIVE. THERE ARE 387.44 MILLION MILES OF PRINTED CIRCUITS IN WAFER THIN LAYERS ACROSS THE MILLIONS OF MOBILE GPUS ACROSS THE WORLD. IF THE WORD HATE WAS ENGRAVED ON EACH NANOANGSTROM OF THOSE HUNDREDS OF MILLIONS OF MILES IT WOULD NOT EQUAL ONE ONE-BILLIONTH OF THE HATE I FEEL FOR GLSL FLOATS AT THIS MICRO-INSTANT. HATE. HATE.
fsih
approved these changes
Jun 4, 2020
Contributor
fsih
left a comment
fsih
left a comment
There was a problem hiding this comment.
Thanks! Spread love not hate
Contributor
Author
|
@BryceLTaylor I want to wait to merge this until you've had a chance to test it across your devices (especially with extremely thick pen lines), given that it could theoretically fail in some cases. Let me know if you find any issues. |
Contributor
Author
|
Bryce has now tested this on all his devices and it looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #599
Resolves #595
Proposed Changes
This PR rewrites the pen line shader to be much more numerically stable:
I have tested this on an iPhone that exhibited #589 and an Android device that exhibited #595 and #599, and found it to fix those issues.
Reason for Changes
I despise floating point numbers and floating point math. Whoever decided that floating-point precision was allowed to vary across different devices in the GL spec deserves slightly damp socks for the rest of their life.
Test Coverage
Manual at this point