fix: increase strictness of BuiltinHelper

Ray Schamp · Ray Schamp · commit 6da12729f859 · 2018-08-23T11:47:01.000-04:00
BuiltinHelper should not cache ids of `undefined` or `null`.

BREAKING CHANGE: Began throwing errors when attempting to use `BuiltinHelper.cache` with non-existy ids
diff --git a/src/BuiltinHelper.js b/src/BuiltinHelper.js
@@ -106,6 +106,8 @@ class BuiltinHelper extends Helper {
             if (this.assets.hasOwnProperty(id) && assetType.immutable) return id;
         } else if (assetType.immutable) {
             id = md5(data);
+        } else {
+            throw new Error('Tried to cache data without an id');
         }
         this.assets[id] = {
             type: assetType,

Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,8 @@ class BuiltinHelper extends Helper {`
`106`	`106`	`if (this.assets.hasOwnProperty(id) && assetType.immutable) return id;`
`107`	`107`	`} else if (assetType.immutable) {`
`108`	`108`	`id = md5(data);`
	`109`	`+ } else {`
	`110`	`+ throw new Error('Tried to cache data without an id');`
`109`	`111`	`}`
`110`	`112`	`this.assets[id] = {`
`111`	`113`	`type: assetType,`