Drop single-stepping and pause modes #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Noooooo!!!!! |
Contributor
Author
|
@CosmicWebServices Haha, I'm sorry. I hope something like them will come back eventually... |
Contributor
|
😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a design discussion yesterday, it seems that both of these would need to be reimplemented in a different way. Also, I realized that this implementation doesn't match Scratch 1.0 single-stepping. In that implementation, execution proceeds to step through threads in the same order it would in normal mode. But, in this implementation, it allows all threads to be stepped in a single stepThreads, which actually changes the execution behavior. If we want a correct implementation, it would need to be redone.