Fix instantiation of failed_data_row_ids in Batch #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
requested review from
a team,
sqlboy,
adrian-chang and
richardsun0713
kopreschko
approved these changes
Nov 3, 2023
vbrodsky
force-pushed
the
VB/fix-batch-failed-rows_attr_SDK-406
branch
from
853bf29 to
19739e1
Compare
adrian-chang
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK story: https://labelbox.atlassian.net/browse/SDK-406
Incorrect handling of the member variable
failed_data_row_idsin theBatchclass results in the failure of the_create_batch_asyncmethod. This issue becomes evident when using thecreate_batchmethod for more than 1,000 data rows. This problem impacts not only Airbnb but also any other client using this SDK call for a larger volume of data rows exceeding 1,000.