Skip to content

Fix instantiation of failed_data_row_ids in Batch #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix instantiation of failed_data_row_ids in Batch #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion labelbox/schema/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def __init__(self,
client,
project_id,
*args,
failed_data_row_ids=None,
failed_data_row_ids=[],
**kwargs):
super().__init__(client, *args, **kwargs)
self.project_id = project_id
Expand Down Expand Up @@ -187,6 +187,11 @@ def delete_labels(self, set_labels_as_template=False) -> None:
experimental=True)
return res

# modify this function to return an empty list if there are no failed data rows

@property
def failed_data_row_ids(self):
if self._failed_data_row_ids is None:
self._failed_data_row_ids = []

return (x for x in self._failed_data_row_ids)
11 changes: 10 additions & 1 deletion tests/integration/test_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,17 @@ def get_data_row_ids(ds: Dataset):


def test_create_batch(project: Project, big_dataset_data_row_ids: List[str]):
batch = project.create_batch("test-batch", big_dataset_data_row_ids, 3)
batch = project.create_batch("test-batch",
big_dataset_data_row_ids,
3,
consensus_settings={
'number_of_labels': 3,
'coverage_percentage': 0.1
})

assert batch.name == "test-batch"
assert batch.size == len(big_dataset_data_row_ids)
assert len([dr for dr in batch.failed_data_row_ids]) == 0


def test_create_batch_with_invalid_data_rows_ids(project: Project):
Expand Down Expand Up @@ -101,6 +109,7 @@ def test_create_batch_async(project: Project,
priority=3)
assert batch.name == "big-batch"
assert batch.size == len(big_dataset_data_row_ids)
assert len([dr for dr in batch.failed_data_row_ids]) == 0


def test_create_batch_with_consensus_settings(project: Project,
Expand Down