[AL-2290] Add result field to Task and get_result() #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2022 17:41
msokoloff1
reviewed
May 25, 2022
msokoloff1
reviewed
May 25, 2022
labelbox/schema/task.py
Outdated
| response = requests.get(self.result) | ||
| response.raise_for_status() | ||
| return response.text | ||
| return "" |
There was a problem hiding this comment.
it might be good to return None vs an empty string. That way an empty response is clearly different from a result that doesn't exist.
msokoloff1
reviewed
May 25, 2022
labelbox/schema/task.py
Outdated
| if self.result: | ||
| response = requests.get(self.result) | ||
| response.raise_for_status() | ||
| return response.text |
There was a problem hiding this comment.
Should this return some sort of json? We are going to have to support some sort of schema here which is why we were waiting to add this feature. Unless this is just an error message it prob shouldn't be a string.
msokoloff1
reviewed
Jun 1, 2022
labelbox/schema/task.py
Outdated
| response = requests.get(self.result) | ||
| response.raise_for_status() | ||
| data = response.json() | ||
| return data['error'] |
msokoloff1
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://labelbox.atlassian.net/browse/AL-2290