-
Notifications
You must be signed in to change notification settings - Fork 68
[AL-2290] Add result field to Task and get_result() #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e9fd9c3
Add result field to Task and get_result()
d4fb122
Fixing style
037c4e5
Adding to mypy.ini
660819a
Removing validators and code changes to dataset.py
a621f67
Get rid of newline at dataset
6ed00c4
Remove changes for db_object
e718d43
Removing unused import
e322a25
Change get_result() to errors(), and only return result for failed dtask
89f3bf4
Remove return type for Task.errors()
f3d9476
Check for 'error' key
ab15e2f
Change task.error() to return None if 'error' doesn't exist
5954537
Add tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,4 +11,4 @@ ignore_missing_imports = True | |
ignore_errors = True | ||
|
||
[mypy-labelbox] | ||
ignore_errors = True | ||
ignore_errors = True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
from labelbox import DataRow | ||
from labelbox.schema.data_row_metadata import DataRowMetadataField | ||
|
||
EMBEDDING_SCHEMA_ID = "ckpyije740000yxdk81pbgjdc" | ||
|
||
|
||
def test_task_errors(dataset, image_url): | ||
client = dataset.client | ||
embeddings = [0.0] * 128 | ||
task = dataset.create_data_rows([ | ||
{ | ||
DataRow.row_data: | ||
image_url, | ||
DataRow.metadata_fields: [ | ||
DataRowMetadataField(schema_id=EMBEDDING_SCHEMA_ID, | ||
value=embeddings), | ||
DataRowMetadataField(schema_id=EMBEDDING_SCHEMA_ID, | ||
value=embeddings) | ||
] | ||
}, | ||
]) | ||
assert task in client.get_user().created_tasks() | ||
task.wait_till_done() | ||
assert task.status == "FAILED" | ||
assert task.errors() is not None | ||
assert 'message' in task.errors() | ||
|
||
|
||
def test_task_success(dataset, image_url): | ||
client = dataset.client | ||
task = dataset.create_data_rows([ | ||
{ | ||
DataRow.row_data: image_url, | ||
}, | ||
]) | ||
assert task in client.get_user().created_tasks() | ||
task.wait_till_done() | ||
assert task.status == "COMPLETE" | ||
assert task.errors() is None |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.