LibWeb: Allow whitespace in not after a boolean-expr-group

lpas · gmta · commit 14dba8220243 · 2025-10-28T21:54:48.000-07:00
diff --git a/Libraries/LibWeb/CSS/Parser/Parser.cpp b/Libraries/LibWeb/CSS/Parser/Parser.cpp
@@ -220,6 +220,7 @@ OwnPtr<BooleanExpression> Parser::parse_boolean_expression(TokenStream<Component
         tokens.discard_whitespace();
 
         if (auto child = parse_boolean_expression_group(tokens, result_for_general_enclosed, parse_test)) {
+            tokens.discard_whitespace();
             transaction.commit();
             return BooleanNotExpression::create(child.release_nonnull());
         }
diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-conditional/at-supports-whitespace.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-conditional/at-supports-whitespace.txt
@@ -0,0 +1,21 @@
+Harness status: OK
+
+Found 16 tests
+
+16 Pass
+Pass	@supports ((a)) {}
+Pass	@supports ((a) ) {}
+Pass	@supports ( (a)) {}
+Pass	@supports ( (a) ) {}
+Pass	@supports (not (a)) {}
+Pass	@supports (not (a) ) {}
+Pass	@supports ( not (a)) {}
+Pass	@supports ( not (a) ) {}
+Pass	@supports ((a) and (b)) {}
+Pass	@supports ((a) and (b) ) {}
+Pass	@supports ( (a) and (b)) {}
+Pass	@supports ( (a) and (b) ) {}
+Pass	@supports ((a) or (b)) {}
+Pass	@supports ((a) or (b) ) {}
+Pass	@supports ( (a) or (b)) {}
+Pass	@supports ( (a) or (b) ) {}
diff --git a/Tests/LibWeb/Text/input/wpt-import/css/css-conditional/at-supports-whitespace.html b/Tests/LibWeb/Text/input/wpt-import/css/css-conditional/at-supports-whitespace.html
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<title>Parsing of @supports with whitespace</title>
+<link rel="help" href="https://drafts.csswg.org/css-conditional-3/#at-supports">
+<script src=../../resources/testharness.js></script>
+<script src=../../resources/testharnessreport.js></script>
+<main id=main></main>
+<script>
+  let examples = [
+    '@supports ((a)) {}',
+    '@supports ((a) ) {}',
+    '@supports ( (a)) {}',
+    '@supports ( (a) ) {}',
+
+    '@supports (not (a)) {}',
+    '@supports (not (a) ) {}',
+    '@supports ( not (a)) {}',
+    '@supports ( not (a) ) {}',
+
+    '@supports ((a) and (b)) {}',
+    '@supports ((a) and (b) ) {}',
+    '@supports ( (a) and (b)) {}',
+    '@supports ( (a) and (b) ) {}',
+
+    '@supports ((a) or (b)) {}',
+    '@supports ((a) or (b) ) {}',
+    '@supports ( (a) or (b)) {}',
+    '@supports ( (a) or (b) ) {}',
+  ];
+
+  for (let example of examples) {
+    test((t) => {
+      let style = document.createElement('style');
+      t.add_cleanup(() => style.remove());
+      style.textContent = example;
+      main.append(style);
+      assert_equals(style.sheet.rules.length, 1);
+    }, example);
+  }
+</script>

Original file line number	Diff line number	Diff line change
`@@ -220,6 +220,7 @@ OwnPtr<BooleanExpression> Parser::parse_boolean_expression(TokenStream<Component`
`220`	`220`	`tokens.discard_whitespace();`
`221`	`221`
`222`	`222`	`if (auto child = parse_boolean_expression_group(tokens, result_for_general_enclosed, parse_test)) {`
	`223`	`+ tokens.discard_whitespace();`
`223`	`224`	`transaction.commit();`
`224`	`225`	`return BooleanNotExpression::create(child.release_nonnull());`
`225`	`226`	`}`