LibWeb: Implement WebGL getVertexAttribOffset

Author: cqundefine

Libraries/LibWeb/WebGL/WebGL2RenderingContextImpl.cpp

@@ -3193,6 +3193,18 @@ JS::Value WebGL2RenderingContextImpl::get_vertex_attrib(WebIDL::UnsignedLong ind
     }
 }
 
+WebIDL::LongLong WebGL2RenderingContextImpl::get_vertex_attrib_offset(WebIDL::UnsignedLong index, WebIDL::UnsignedLong pname)
+{
+    if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER) {
+        set_error(GL_INVALID_ENUM);
+        return 0;
+    }
+
+    GLintptr result { 0 };
+    glGetVertexAttribPointervRobustANGLE(index, GL_VERTEX_ATTRIB_ARRAY_POINTER, 1, nullptr, reinterpret_cast<void**>(&result));
+    return result;
+}
+
 void WebGL2RenderingContextImpl::hint(WebIDL::UnsignedLong target, WebIDL::UnsignedLong mode)
 {
     m_context->make_current();

Libraries/LibWeb/WebGL/WebGL2RenderingContextImpl.h

@@ -200,6 +200,7 @@ class WebGL2RenderingContextImpl : public WebGLRenderingContextBase {
     JS::Value get_uniform(GC::Root<WebGLProgram> program, GC::Root<WebGLUniformLocation> location);
     GC::Root<WebGLUniformLocation> get_uniform_location(GC::Root<WebGLProgram> program, String name);
     JS::Value get_vertex_attrib(WebIDL::UnsignedLong index, WebIDL::UnsignedLong pname);
+    WebIDL::LongLong get_vertex_attrib_offset(WebIDL::UnsignedLong index, WebIDL::UnsignedLong pname);
     void hint(WebIDL::UnsignedLong target, WebIDL::UnsignedLong mode);
     bool is_buffer(GC::Root<WebGLBuffer> buffer);
     bool is_enabled(WebIDL::UnsignedLong cap);

Libraries/LibWeb/WebGL/WebGLRenderingContextBase.idl

@@ -133,7 +133,7 @@ interface mixin WebGLRenderingContextBase {
 
     any getVertexAttrib(GLuint index, GLenum pname);
 
-    [FIXME] GLintptr getVertexAttribOffset(GLuint index, GLenum pname);
+    GLintptr getVertexAttribOffset(GLuint index, GLenum pname);
 
     undefined hint(GLenum target, GLenum mode);
     GLboolean isBuffer(WebGLBuffer? buffer);

Libraries/LibWeb/WebGL/WebGLRenderingContextImpl.cpp

@@ -1757,6 +1757,18 @@ JS::Value WebGLRenderingContextImpl::get_vertex_attrib(WebIDL::UnsignedLong inde
     }
 }
 
+WebIDL::LongLong WebGLRenderingContextImpl::get_vertex_attrib_offset(WebIDL::UnsignedLong index, WebIDL::UnsignedLong pname)
+{
+    if (pname != GL_VERTEX_ATTRIB_ARRAY_POINTER) {
+        set_error(GL_INVALID_ENUM);
+        return 0;
+    }
+
+    GLintptr result { 0 };
+    glGetVertexAttribPointervRobustANGLE(index, GL_VERTEX_ATTRIB_ARRAY_POINTER, 1, nullptr, reinterpret_cast<void**>(&result));
+    return result;
+}
+
 void WebGLRenderingContextImpl::hint(WebIDL::UnsignedLong target, WebIDL::UnsignedLong mode)
 {
     m_context->make_current();

Libraries/LibWeb/WebGL/WebGLRenderingContextImpl.h

@@ -115,6 +115,7 @@ class WebGLRenderingContextImpl : public WebGLRenderingContextBase {
     JS::Value get_uniform(GC::Root<WebGLProgram> program, GC::Root<WebGLUniformLocation> location);
     GC::Root<WebGLUniformLocation> get_uniform_location(GC::Root<WebGLProgram> program, String name);
     JS::Value get_vertex_attrib(WebIDL::UnsignedLong index, WebIDL::UnsignedLong pname);
+    WebIDL::LongLong get_vertex_attrib_offset(WebIDL::UnsignedLong index, WebIDL::UnsignedLong pname);
     void hint(WebIDL::UnsignedLong target, WebIDL::UnsignedLong mode);
     bool is_buffer(GC::Root<WebGLBuffer> buffer);
     bool is_enabled(WebIDL::UnsignedLong cap);