LibWeb: Use qualified names for SVG attribute reflectors

Lubrsi · trflynn89 · commit 60e1a136aa2f · 2025-11-06T11:43:06.000-05:00
diff --git a/Libraries/LibWeb/SVG/SVGAElement.cpp b/Libraries/LibWeb/SVG/SVGAElement.cpp
@@ -66,7 +66,7 @@ i32 SVGAElement::default_tab_index_value() const
 GC::Ref<SVGAnimatedString> SVGAElement::target()
 {
     if (!m_target)
-        m_target = SVGAnimatedString::create(realm(), *this, HTML::AttributeNames::target);
+        m_target = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { HTML::AttributeNames::target, OptionalNone {}, OptionalNone {} });
     return *m_target;
 }
 
diff --git a/Libraries/LibWeb/SVG/SVGAnimatedNumber.cpp b/Libraries/LibWeb/SVG/SVGAnimatedNumber.cpp
@@ -15,14 +15,14 @@ namespace Web::SVG {
 GC_DEFINE_ALLOCATOR(SVGAnimatedNumber);
 
 GC::Ref<SVGAnimatedNumber> SVGAnimatedNumber::create(JS::Realm& realm, GC::Ref<SVGElement> element,
-    FlyString reflected_attribute, float initial_value, SupportsSecondValue supports_second_value,
+    DOM::QualifiedName reflected_attribute, float initial_value, SupportsSecondValue supports_second_value,
     ValueRepresented value_represented)
 {
     return realm.create<SVGAnimatedNumber>(realm, element, move(reflected_attribute), initial_value,
         supports_second_value, value_represented);
 }
 
-SVGAnimatedNumber::SVGAnimatedNumber(JS::Realm& realm, GC::Ref<SVGElement> element, FlyString reflected_attribute,
+SVGAnimatedNumber::SVGAnimatedNumber(JS::Realm& realm, GC::Ref<SVGElement> element, DOM::QualifiedName reflected_attribute,
     float initial_value, SupportsSecondValue supports_second_value, ValueRepresented value_represented)
     : PlatformObject(realm)
     , m_element(element)
@@ -55,7 +55,7 @@ void SVGAnimatedNumber::set_base_val(float new_value)
     if (m_supports_second_value == SupportsSecondValue::Yes) {
         // 1. Let current be the value of the reflected attribute (using the attribute's initial value if it is not
         //    present or invalid).
-        auto current = m_element->get_attribute_value(m_reflected_attribute);
+        auto current = m_element->get_attribute_value(m_reflected_attribute.local_name(), m_reflected_attribute.namespace_());
         auto current_values = MUST(current.split(' '));
 
         // 2. Let first be the first number in current.
@@ -93,7 +93,7 @@ void SVGAnimatedNumber::set_base_val(float new_value)
     //    (given the implementation's supported Precisionreal number precision), joined and separated by a single U+0020
     //    SPACE character.
     auto new_attribute_value = MUST(String::join(' ', new_));
-    m_element->set_attribute_value(m_reflected_attribute, new_attribute_value);
+    m_element->set_attribute_value(m_reflected_attribute.local_name(), new_attribute_value, m_reflected_attribute.prefix(), m_reflected_attribute.namespace_());
 }
 
 // https://svgwg.org/svg2-draft/types.html#__svg__SVGAnimatedNumber__animVal
@@ -116,7 +116,7 @@ float SVGAnimatedNumber::get_base_or_anim_value() const
 {
     // 1. Let value be the value of the reflected attribute (using the attribute's initial value if it is not present or
     //    invalid).
-    auto value = m_element->get_attribute_value(m_reflected_attribute);
+    auto value = m_element->get_attribute_value(m_reflected_attribute.local_name(), m_reflected_attribute.namespace_());
 
     // 2. If the reflected attribute is defined to take an number followed by an optional second number, then:
     if (m_supports_second_value == SupportsSecondValue::Yes) {
diff --git a/Libraries/LibWeb/SVG/SVGAnimatedNumber.h b/Libraries/LibWeb/SVG/SVGAnimatedNumber.h
@@ -28,7 +28,7 @@ class SVGAnimatedNumber final : public Bindings::PlatformObject {
     };
 
     [[nodiscard]] static GC::Ref<SVGAnimatedNumber> create(JS::Realm&, GC::Ref<SVGElement>,
-        FlyString reflected_attribute, float initial_value, SupportsSecondValue = SupportsSecondValue::No,
+        DOM::QualifiedName reflected_attribute, float initial_value, SupportsSecondValue = SupportsSecondValue::No,
         ValueRepresented = ValueRepresented::First);
     virtual ~SVGAnimatedNumber() override;
 
@@ -38,7 +38,7 @@ class SVGAnimatedNumber final : public Bindings::PlatformObject {
     float anim_val() const;
 
 private:
-    SVGAnimatedNumber(JS::Realm&, GC::Ref<SVGElement>, FlyString, float, SupportsSecondValue, ValueRepresented);
+    SVGAnimatedNumber(JS::Realm&, GC::Ref<SVGElement>, DOM::QualifiedName, float, SupportsSecondValue, ValueRepresented);
 
     virtual void initialize(JS::Realm&) override;
     virtual void visit_edges(Visitor&) override;
@@ -47,7 +47,7 @@ class SVGAnimatedNumber final : public Bindings::PlatformObject {
     float get_base_or_anim_value() const;
 
     GC::Ref<SVGElement> m_element;
-    FlyString m_reflected_attribute;
+    DOM::QualifiedName m_reflected_attribute;
     float m_initial_value;
     SupportsSecondValue m_supports_second_value;
     ValueRepresented m_value_represented;
diff --git a/Libraries/LibWeb/SVG/SVGAnimatedString.cpp b/Libraries/LibWeb/SVG/SVGAnimatedString.cpp
@@ -15,12 +15,12 @@ namespace Web::SVG {
 
 GC_DEFINE_ALLOCATOR(SVGAnimatedString);
 
-GC::Ref<SVGAnimatedString> SVGAnimatedString::create(JS::Realm& realm, GC::Ref<SVGElement> element, FlyString reflected_attribute, Optional<FlyString> deprecated_reflected_attribute, Optional<FlyString> initial_value)
+GC::Ref<SVGAnimatedString> SVGAnimatedString::create(JS::Realm& realm, GC::Ref<SVGElement> element, DOM::QualifiedName reflected_attribute, Optional<DOM::QualifiedName> deprecated_reflected_attribute, Optional<FlyString> initial_value)
 {
     return realm.create<SVGAnimatedString>(realm, element, move(reflected_attribute), move(deprecated_reflected_attribute), move(initial_value));
 }
 
-SVGAnimatedString::SVGAnimatedString(JS::Realm& realm, GC::Ref<SVGElement> element, FlyString reflected_attribute, Optional<FlyString> deprecated_reflected_attribute, Optional<FlyString> initial_value)
+SVGAnimatedString::SVGAnimatedString(JS::Realm& realm, GC::Ref<SVGElement> element, DOM::QualifiedName reflected_attribute, Optional<DOM::QualifiedName> deprecated_reflected_attribute, Optional<FlyString> initial_value)
     : Bindings::PlatformObject(realm)
     , m_element(element)
     , m_reflected_attribute(move(reflected_attribute))
@@ -48,11 +48,11 @@ String SVGAnimatedString::base_val() const
 {
     // On getting baseVal or animVal, the following steps are run:
     // 1. If the reflected attribute is not present, then:
-    if (!m_element->has_attribute(m_reflected_attribute)) {
+    if (!m_element->has_attribute_ns(m_reflected_attribute.namespace_(), m_reflected_attribute.local_name())) {
         // 1. If the SVGAnimatedString object is defined to additionally reflect a second, deprecated attribute,
         //    and that attribute is present, then return its value.
         if (m_deprecated_reflected_attribute.has_value()) {
-            if (auto attribute = m_element->get_attribute(m_deprecated_reflected_attribute.value()); attribute.has_value())
+            if (auto attribute = m_element->get_attribute_ns(m_deprecated_reflected_attribute->namespace_(), m_deprecated_reflected_attribute->local_name()); attribute.has_value())
                 return attribute.release_value();
         }
 
@@ -65,7 +65,7 @@ String SVGAnimatedString::base_val() const
     }
 
     // 2. Otherwise, the reflected attribute is present. Return its value.
-    return m_element->attribute(m_reflected_attribute).value();
+    return m_element->get_attribute_ns(m_reflected_attribute.namespace_(), m_reflected_attribute.local_name()).value();
 }
 
 // https://svgwg.org/svg2-draft/types.html#__svg__SVGAnimatedString__baseVal
@@ -74,15 +74,15 @@ void SVGAnimatedString::set_base_val(String const& base_val)
     // 1. If the reflected attribute is not present, the SVGAnimatedString object is defined to additionally reflect
     //    a second, deprecated attribute, and that deprecated attribute is present, then set that deprecated attribute
     //    to the specified value.
-    if (!m_element->has_attribute(m_reflected_attribute)
+    if (!m_element->has_attribute_ns(m_reflected_attribute.namespace_(), m_reflected_attribute.local_name())
         && m_deprecated_reflected_attribute.has_value()
-        && m_element->has_attribute(m_deprecated_reflected_attribute.value())) {
-        MUST(m_element->set_attribute(m_deprecated_reflected_attribute.value(), base_val));
+        && m_element->has_attribute_ns(m_deprecated_reflected_attribute->namespace_(), m_deprecated_reflected_attribute->local_name())) {
+        m_element->set_attribute_value(m_deprecated_reflected_attribute->local_name(), base_val, m_deprecated_reflected_attribute->prefix(), m_deprecated_reflected_attribute->namespace_());
         return;
     }
 
     // 2. Otherwise, set the reflected attribute to the specified value.
-    MUST(m_element->set_attribute(m_reflected_attribute, base_val));
+    m_element->set_attribute_value(m_reflected_attribute.local_name(), base_val, m_reflected_attribute.prefix(), m_reflected_attribute.namespace_());
 }
 
 }
diff --git a/Libraries/LibWeb/SVG/SVGAnimatedString.h b/Libraries/LibWeb/SVG/SVGAnimatedString.h
@@ -8,6 +8,7 @@
 
 #include <AK/FlyString.h>
 #include <LibWeb/Bindings/PlatformObject.h>
+#include <LibWeb/DOM/QualifiedName.h>
 #include <LibWeb/Export.h>
 
 namespace Web::SVG {
@@ -18,21 +19,21 @@ class WEB_API SVGAnimatedString final : public Bindings::PlatformObject {
     GC_DECLARE_ALLOCATOR(SVGAnimatedString);
 
 public:
-    [[nodiscard]] static GC::Ref<SVGAnimatedString> create(JS::Realm&, GC::Ref<SVGElement> element, FlyString reflected_attribute, Optional<FlyString> deprecated_reflected_attribute = {}, Optional<FlyString> initial_value = {});
+    [[nodiscard]] static GC::Ref<SVGAnimatedString> create(JS::Realm&, GC::Ref<SVGElement> element, DOM::QualifiedName reflected_attribute, Optional<DOM::QualifiedName> deprecated_reflected_attribute = {}, Optional<FlyString> initial_value = {});
     virtual ~SVGAnimatedString() override;
 
     String base_val() const;
     void set_base_val(String const& base_val);
 
 private:
-    SVGAnimatedString(JS::Realm&, GC::Ref<SVGElement> element, FlyString reflected_attribute, Optional<FlyString> deprecated_reflected_attribute, Optional<FlyString> initial_value);
+    SVGAnimatedString(JS::Realm&, GC::Ref<SVGElement> element, DOM::QualifiedName reflected_attribute, Optional<DOM::QualifiedName> deprecated_reflected_attribute, Optional<FlyString> initial_value);
 
     virtual void initialize(JS::Realm&) override;
     virtual void visit_edges(Cell::Visitor&) override;
 
     GC::Ref<SVGElement> m_element;
-    FlyString m_reflected_attribute;
-    Optional<FlyString> m_deprecated_reflected_attribute;
+    DOM::QualifiedName m_reflected_attribute;
+    Optional<DOM::QualifiedName> m_deprecated_reflected_attribute;
     Optional<FlyString> m_initial_value;
 };
 
diff --git a/Libraries/LibWeb/SVG/SVGElement.cpp b/Libraries/LibWeb/SVG/SVGElement.cpp
@@ -279,7 +279,7 @@ GC::Ref<SVGAnimatedString> SVGElement::class_name()
 {
     // The className IDL attribute reflects the ‘class’ attribute.
     if (!m_class_name_animated_string)
-        m_class_name_animated_string = SVGAnimatedString::create(realm(), *this, AttributeNames::class_);
+        m_class_name_animated_string = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::class_, OptionalNone {}, OptionalNone {} });
 
     return *m_class_name_animated_string;
 }
diff --git a/Libraries/LibWeb/SVG/SVGFEBlendElement.cpp b/Libraries/LibWeb/SVG/SVGFEBlendElement.cpp
@@ -55,15 +55,15 @@ void SVGFEBlendElement::attribute_changed(FlyString const& name, Optional<String
 GC::Ref<SVGAnimatedString> SVGFEBlendElement::in1()
 {
     if (!m_in1)
-        m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);
+        m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });
 
     return *m_in1;
 }
 
 GC::Ref<SVGAnimatedString> SVGFEBlendElement::in2()
 {
     if (!m_in2)
-        m_in2 = SVGAnimatedString::create(realm(), *this, AttributeNames::in2);
+        m_in2 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in2, OptionalNone {}, OptionalNone {} });
 
     return *m_in2;
 }
diff --git a/Libraries/LibWeb/SVG/SVGFEColorMatrixElement.cpp b/Libraries/LibWeb/SVG/SVGFEColorMatrixElement.cpp
@@ -35,7 +35,7 @@ void SVGFEColorMatrixElement::visit_edges(Cell::Visitor& visitor)
 GC::Ref<SVGAnimatedString> SVGFEColorMatrixElement::in1()
 {
     if (!m_in1)
-        m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);
+        m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });
     return *m_in1;
 }
 
@@ -62,7 +62,7 @@ GC::Ref<SVGAnimatedEnumeration> SVGFEColorMatrixElement::type() const
 GC::Ref<SVGAnimatedString> SVGFEColorMatrixElement::values()
 {
     if (!m_values)
-        m_values = SVGAnimatedString::create(realm(), *this, AttributeNames::values);
+        m_values = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::values, OptionalNone {}, OptionalNone {} });
     return *m_values;
 }
 
diff --git a/Libraries/LibWeb/SVG/SVGFECompositeElement.cpp b/Libraries/LibWeb/SVG/SVGFECompositeElement.cpp
@@ -70,15 +70,15 @@ void SVGFECompositeElement::attribute_changed(FlyString const& name, Optional<St
 GC::Ref<SVGAnimatedString> SVGFECompositeElement::in1()
 {
     if (!m_in1)
-        m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);
+        m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });
 
     return *m_in1;
 }
 
 GC::Ref<SVGAnimatedString> SVGFECompositeElement::in2()
 {
     if (!m_in2)
-        m_in2 = SVGAnimatedString::create(realm(), *this, AttributeNames::in2);
+        m_in2 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in2, OptionalNone {}, OptionalNone {} });
 
     return *m_in2;
 }
@@ -87,7 +87,7 @@ GC::Ref<SVGAnimatedString> SVGFECompositeElement::in2()
 GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k1()
 {
     if (!m_k1)
-        m_k1 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k1, 0.f);
+        m_k1 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k1, OptionalNone {}, OptionalNone {} }, 0.f);
 
     return *m_k1;
 }
@@ -96,7 +96,7 @@ GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k1()
 GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k2()
 {
     if (!m_k2)
-        m_k2 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k2, 0.f);
+        m_k2 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k2, OptionalNone {}, OptionalNone {} }, 0.f);
 
     return *m_k2;
 }
@@ -105,7 +105,7 @@ GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k2()
 GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k3()
 {
     if (!m_k3)
-        m_k3 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k3, 0.f);
+        m_k3 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k3, OptionalNone {}, OptionalNone {} }, 0.f);
 
     return *m_k3;
 }
@@ -114,7 +114,7 @@ GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k3()
 GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k4()
 {
     if (!m_k4)
-        m_k4 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k4, 0.f);
+        m_k4 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k4, OptionalNone {}, OptionalNone {} }, 0.f);
 
     return *m_k4;
 }
diff --git a/Libraries/LibWeb/SVG/SVGFEGaussianBlurElement.cpp b/Libraries/LibWeb/SVG/SVGFEGaussianBlurElement.cpp
@@ -37,7 +37,7 @@ void SVGFEGaussianBlurElement::visit_edges(Cell::Visitor& visitor)
 GC::Ref<SVGAnimatedString> SVGFEGaussianBlurElement::in1()
 {
     if (!m_in1)
-        m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);
+        m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });
 
     return *m_in1;
 }
@@ -46,7 +46,7 @@ GC::Ref<SVGAnimatedString> SVGFEGaussianBlurElement::in1()
 GC::Ref<SVGAnimatedNumber> SVGFEGaussianBlurElement::std_deviation_x()
 {
     if (!m_std_deviation_x) {
-        m_std_deviation_x = SVGAnimatedNumber::create(realm(), *this, AttributeNames::stdDeviation, 0.f,
+        m_std_deviation_x = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::stdDeviation, OptionalNone {}, OptionalNone {} }, 0.f,
             SVGAnimatedNumber::SupportsSecondValue::Yes, SVGAnimatedNumber::ValueRepresented::First);
     }
     return *m_std_deviation_x;
@@ -56,7 +56,7 @@ GC::Ref<SVGAnimatedNumber> SVGFEGaussianBlurElement::std_deviation_x()
 GC::Ref<SVGAnimatedNumber> SVGFEGaussianBlurElement::std_deviation_y()
 {
     if (!m_std_deviation_y) {
-        m_std_deviation_y = SVGAnimatedNumber::create(realm(), *this, AttributeNames::stdDeviation, 0.f,
+        m_std_deviation_y = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::stdDeviation, OptionalNone {}, OptionalNone {} }, 0.f,
             SVGAnimatedNumber::SupportsSecondValue::Yes, SVGAnimatedNumber::ValueRepresented::Second);
     }
     return *m_std_deviation_y;
diff --git a/Libraries/LibWeb/SVG/SVGFEMergeNodeElement.cpp b/Libraries/LibWeb/SVG/SVGFEMergeNodeElement.cpp
@@ -32,7 +32,7 @@ void SVGFEMergeNodeElement::visit_edges(Cell::Visitor& visitor)
 GC::Ref<SVGAnimatedString> SVGFEMergeNodeElement::in1()
 {
     if (!m_in1)
-        m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);
+        m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });
 
     return *m_in1;
 }
diff --git a/Libraries/LibWeb/SVG/SVGFEOffsetElement.cpp b/Libraries/LibWeb/SVG/SVGFEOffsetElement.cpp
@@ -35,7 +35,7 @@ void SVGFEOffsetElement::visit_edges(Cell::Visitor& visitor)
 GC::Ref<SVGAnimatedString> SVGFEOffsetElement::in1()
 {
     if (!m_in1)
-        m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);
+        m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });
 
     return *m_in1;
 }
@@ -44,7 +44,7 @@ GC::Ref<SVGAnimatedString> SVGFEOffsetElement::in1()
 GC::Ref<SVGAnimatedNumber> SVGFEOffsetElement::dx()
 {
     if (!m_dx) {
-        m_dx = SVGAnimatedNumber::create(realm(), *this, AttributeNames::dx, 0.f,
+        m_dx = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::dx, OptionalNone {}, OptionalNone {} }, 0.f,
             SVGAnimatedNumber::SupportsSecondValue::Yes, SVGAnimatedNumber::ValueRepresented::First);
     }
     return *m_dx;
@@ -54,7 +54,7 @@ GC::Ref<SVGAnimatedNumber> SVGFEOffsetElement::dx()
 GC::Ref<SVGAnimatedNumber> SVGFEOffsetElement::dy()
 {
     if (!m_dy) {
-        m_dy = SVGAnimatedNumber::create(realm(), *this, AttributeNames::dy, 0.f,
+        m_dy = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::dy, OptionalNone {}, OptionalNone {} }, 0.f,
             SVGAnimatedNumber::SupportsSecondValue::Yes, SVGAnimatedNumber::ValueRepresented::Second);
     }
     return *m_dy;
diff --git a/Libraries/LibWeb/SVG/SVGFilterPrimitiveStandardAttributes.cpp b/Libraries/LibWeb/SVG/SVGFilterPrimitiveStandardAttributes.cpp
@@ -46,7 +46,7 @@ template<typename IncludingClass>
 GC::Ref<SVGAnimatedString> SVGFilterPrimitiveStandardAttributes<IncludingClass>::result()
 {
     if (!m_result_animated_string)
-        m_result_animated_string = SVGAnimatedString::create(this_svg_element()->realm(), *this_svg_element(), AttributeNames::result);
+        m_result_animated_string = SVGAnimatedString::create(this_svg_element()->realm(), *this_svg_element(), DOM::QualifiedName { AttributeNames::result, OptionalNone {}, OptionalNone {} });
 
     return *m_result_animated_string;
 }
diff --git a/Libraries/LibWeb/SVG/SVGGeometryElement.cpp b/Libraries/LibWeb/SVG/SVGGeometryElement.cpp
@@ -47,7 +47,7 @@ GC::Ref<Geometry::DOMPoint> SVGGeometryElement::get_point_at_length(float distan
 GC::Ref<SVGAnimatedNumber> SVGGeometryElement::path_length()
 {
     if (!m_path_length)
-        m_path_length = SVGAnimatedNumber::create(realm(), *this, AttributeNames::pathLength, 0.f);
+        m_path_length = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::pathLength, OptionalNone {}, OptionalNone {} }, 0.f);
     return *m_path_length;
 }
 
diff --git a/Libraries/LibWeb/SVG/SVGStopElement.cpp b/Libraries/LibWeb/SVG/SVGStopElement.cpp
@@ -63,7 +63,7 @@ float SVGStopElement::stop_opacity() const
 GC::Ref<SVGAnimatedNumber> SVGStopElement::offset()
 {
     if (!m_stop_offset)
-        m_stop_offset = SVGAnimatedNumber::create(realm(), *this, AttributeNames::offset, 0.f);
+        m_stop_offset = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::offset, OptionalNone {}, OptionalNone {} }, 0.f);
     return *m_stop_offset;
 }
 
diff --git a/Libraries/LibWeb/SVG/SVGURIReference.h b/Libraries/LibWeb/SVG/SVGURIReference.h

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ i32 SVGAElement::default_tab_index_value() const`
`66`	`66`	`GC::Ref<SVGAnimatedString> SVGAElement::target()`
`67`	`67`	`{`
`68`	`68`	`if (!m_target)`
`69`		`- m_target = SVGAnimatedString::create(realm(), *this, HTML::AttributeNames::target);`
	`69`	`+ m_target = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { HTML::AttributeNames::target, OptionalNone {}, OptionalNone {} });`
`70`	`70`	`return *m_target;`
`71`	`71`	`}`
`72`	`72`
Original file line number	Diff line number	Diff line change
`@@ -15,12 +15,12 @@ namespace Web::SVG {`
`15`	`15`
`16`	`16`	`GC_DEFINE_ALLOCATOR(SVGAnimatedString);`
`17`	`17`
`18`		`-GC::Ref<SVGAnimatedString> SVGAnimatedString::create(JS::Realm& realm, GC::Ref<SVGElement> element, FlyString reflected_attribute, Optional<FlyString> deprecated_reflected_attribute, Optional<FlyString> initial_value)`
	`18`	`+GC::Ref<SVGAnimatedString> SVGAnimatedString::create(JS::Realm& realm, GC::Ref<SVGElement> element, DOM::QualifiedName reflected_attribute, Optional<DOM::QualifiedName> deprecated_reflected_attribute, Optional<FlyString> initial_value)`
`19`	`19`	`{`
`20`	`20`	`return realm.create<SVGAnimatedString>(realm, element, move(reflected_attribute), move(deprecated_reflected_attribute), move(initial_value));`
`21`	`21`	`}`
`22`	`22`
`23`		`-SVGAnimatedString::SVGAnimatedString(JS::Realm& realm, GC::Ref<SVGElement> element, FlyString reflected_attribute, Optional<FlyString> deprecated_reflected_attribute, Optional<FlyString> initial_value)`
	`23`	`+SVGAnimatedString::SVGAnimatedString(JS::Realm& realm, GC::Ref<SVGElement> element, DOM::QualifiedName reflected_attribute, Optional<DOM::QualifiedName> deprecated_reflected_attribute, Optional<FlyString> initial_value)`
`24`	`24`	`: Bindings::PlatformObject(realm)`
`25`	`25`	`, m_element(element)`
`26`	`26`	`, m_reflected_attribute(move(reflected_attribute))`
`@@ -48,11 +48,11 @@ String SVGAnimatedString::base_val() const`
`48`	`48`	`{`
`49`	`49`	`// On getting baseVal or animVal, the following steps are run:`
`50`	`50`	`// 1. If the reflected attribute is not present, then:`
`51`		`- if (!m_element->has_attribute(m_reflected_attribute)) {`
	`51`	`+ if (!m_element->has_attribute_ns(m_reflected_attribute.namespace_(), m_reflected_attribute.local_name())) {`
`52`	`52`	`// 1. If the SVGAnimatedString object is defined to additionally reflect a second, deprecated attribute,`
`53`	`53`	`// and that attribute is present, then return its value.`
`54`	`54`	`if (m_deprecated_reflected_attribute.has_value()) {`
`55`		`- if (auto attribute = m_element->get_attribute(m_deprecated_reflected_attribute.value()); attribute.has_value())`
	`55`	`+ if (auto attribute = m_element->get_attribute_ns(m_deprecated_reflected_attribute->namespace_(), m_deprecated_reflected_attribute->local_name()); attribute.has_value())`
`56`	`56`	`return attribute.release_value();`
`57`	`57`	`}`
`58`	`58`
`@@ -65,7 +65,7 @@ String SVGAnimatedString::base_val() const`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`// 2. Otherwise, the reflected attribute is present. Return its value.`
`68`		`- return m_element->attribute(m_reflected_attribute).value();`
	`68`	`+ return m_element->get_attribute_ns(m_reflected_attribute.namespace_(), m_reflected_attribute.local_name()).value();`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`// https://svgwg.org/svg2-draft/types.html#__svg__SVGAnimatedString__baseVal`
`@@ -74,15 +74,15 @@ void SVGAnimatedString::set_base_val(String const& base_val)`
`74`	`74`	`// 1. If the reflected attribute is not present, the SVGAnimatedString object is defined to additionally reflect`
`75`	`75`	`// a second, deprecated attribute, and that deprecated attribute is present, then set that deprecated attribute`
`76`	`76`	`// to the specified value.`
`77`		`- if (!m_element->has_attribute(m_reflected_attribute)`
	`77`	`+ if (!m_element->has_attribute_ns(m_reflected_attribute.namespace_(), m_reflected_attribute.local_name())`
`78`	`78`	`&& m_deprecated_reflected_attribute.has_value()`
`79`		`- && m_element->has_attribute(m_deprecated_reflected_attribute.value())) {`
`80`		`- MUST(m_element->set_attribute(m_deprecated_reflected_attribute.value(), base_val));`
	`79`	`+ && m_element->has_attribute_ns(m_deprecated_reflected_attribute->namespace_(), m_deprecated_reflected_attribute->local_name())) {`
	`80`	`+ m_element->set_attribute_value(m_deprecated_reflected_attribute->local_name(), base_val, m_deprecated_reflected_attribute->prefix(), m_deprecated_reflected_attribute->namespace_());`
`81`	`81`	`return;`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`// 2. Otherwise, set the reflected attribute to the specified value.`
`85`		`- MUST(m_element->set_attribute(m_reflected_attribute, base_val));`
	`85`	`+ m_element->set_attribute_value(m_reflected_attribute.local_name(), base_val, m_reflected_attribute.prefix(), m_reflected_attribute.namespace_());`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`}`
Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ GC::Ref<SVGAnimatedString> SVGElement::class_name()`
`279`	`279`	`{`
`280`	`280`	`// The className IDL attribute reflects the ‘class’ attribute.`
`281`	`281`	`if (!m_class_name_animated_string)`
`282`		`- m_class_name_animated_string = SVGAnimatedString::create(realm(), *this, AttributeNames::class_);`
	`282`	`+ m_class_name_animated_string = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::class_, OptionalNone {}, OptionalNone {} });`
`283`	`283`
`284`	`284`	`return *m_class_name_animated_string;`
`285`	`285`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,15 +55,15 @@ void SVGFEBlendElement::attribute_changed(FlyString const& name, Optional<String`
`55`	`55`	`GC::Ref<SVGAnimatedString> SVGFEBlendElement::in1()`
`56`	`56`	`{`
`57`	`57`	`if (!m_in1)`
`58`		`- m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);`
	`58`	`+ m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });`
`59`	`59`
`60`	`60`	`return *m_in1;`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`GC::Ref<SVGAnimatedString> SVGFEBlendElement::in2()`
`64`	`64`	`{`
`65`	`65`	`if (!m_in2)`
`66`		`- m_in2 = SVGAnimatedString::create(realm(), *this, AttributeNames::in2);`
	`66`	`+ m_in2 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in2, OptionalNone {}, OptionalNone {} });`
`67`	`67`
`68`	`68`	`return *m_in2;`
`69`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ void SVGFEColorMatrixElement::visit_edges(Cell::Visitor& visitor)`
`35`	`35`	`GC::Ref<SVGAnimatedString> SVGFEColorMatrixElement::in1()`
`36`	`36`	`{`
`37`	`37`	`if (!m_in1)`
`38`		`- m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);`
	`38`	`+ m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });`
`39`	`39`	`return *m_in1;`
`40`	`40`	`}`
`41`	`41`
`@@ -62,7 +62,7 @@ GC::Ref<SVGAnimatedEnumeration> SVGFEColorMatrixElement::type() const`
`62`	`62`	`GC::Ref<SVGAnimatedString> SVGFEColorMatrixElement::values()`
`63`	`63`	`{`
`64`	`64`	`if (!m_values)`
`65`		`- m_values = SVGAnimatedString::create(realm(), *this, AttributeNames::values);`
	`65`	`+ m_values = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::values, OptionalNone {}, OptionalNone {} });`
`66`	`66`	`return *m_values;`
`67`	`67`	`}`
`68`	`68`
Original file line number	Diff line number	Diff line change
`@@ -70,15 +70,15 @@ void SVGFECompositeElement::attribute_changed(FlyString const& name, Optional<St`
`70`	`70`	`GC::Ref<SVGAnimatedString> SVGFECompositeElement::in1()`
`71`	`71`	`{`
`72`	`72`	`if (!m_in1)`
`73`		`- m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);`
	`73`	`+ m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });`
`74`	`74`
`75`	`75`	`return *m_in1;`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`GC::Ref<SVGAnimatedString> SVGFECompositeElement::in2()`
`79`	`79`	`{`
`80`	`80`	`if (!m_in2)`
`81`		`- m_in2 = SVGAnimatedString::create(realm(), *this, AttributeNames::in2);`
	`81`	`+ m_in2 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in2, OptionalNone {}, OptionalNone {} });`
`82`	`82`
`83`	`83`	`return *m_in2;`
`84`	`84`	`}`
`@@ -87,7 +87,7 @@ GC::Ref<SVGAnimatedString> SVGFECompositeElement::in2()`
`87`	`87`	`GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k1()`
`88`	`88`	`{`
`89`	`89`	`if (!m_k1)`
`90`		`- m_k1 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k1, 0.f);`
	`90`	`+ m_k1 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k1, OptionalNone {}, OptionalNone {} }, 0.f);`
`91`	`91`
`92`	`92`	`return *m_k1;`
`93`	`93`	`}`
`@@ -96,7 +96,7 @@ GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k1()`
`96`	`96`	`GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k2()`
`97`	`97`	`{`
`98`	`98`	`if (!m_k2)`
`99`		`- m_k2 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k2, 0.f);`
	`99`	`+ m_k2 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k2, OptionalNone {}, OptionalNone {} }, 0.f);`
`100`	`100`
`101`	`101`	`return *m_k2;`
`102`	`102`	`}`
`@@ -105,7 +105,7 @@ GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k2()`
`105`	`105`	`GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k3()`
`106`	`106`	`{`
`107`	`107`	`if (!m_k3)`
`108`		`- m_k3 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k3, 0.f);`
	`108`	`+ m_k3 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k3, OptionalNone {}, OptionalNone {} }, 0.f);`
`109`	`109`
`110`	`110`	`return *m_k3;`
`111`	`111`	`}`
`@@ -114,7 +114,7 @@ GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k3()`
`114`	`114`	`GC::Ref<SVGAnimatedNumber> SVGFECompositeElement::k4()`
`115`	`115`	`{`
`116`	`116`	`if (!m_k4)`
`117`		`- m_k4 = SVGAnimatedNumber::create(realm(), *this, AttributeNames::k4, 0.f);`
	`117`	`+ m_k4 = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::k4, OptionalNone {}, OptionalNone {} }, 0.f);`
`118`	`118`
`119`	`119`	`return *m_k4;`
`120`	`120`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ void SVGFEGaussianBlurElement::visit_edges(Cell::Visitor& visitor)`
`37`	`37`	`GC::Ref<SVGAnimatedString> SVGFEGaussianBlurElement::in1()`
`38`	`38`	`{`
`39`	`39`	`if (!m_in1)`
`40`		`- m_in1 = SVGAnimatedString::create(realm(), *this, AttributeNames::in);`
	`40`	`+ m_in1 = SVGAnimatedString::create(realm(), *this, DOM::QualifiedName { AttributeNames::in, OptionalNone {}, OptionalNone {} });`
`41`	`41`
`42`	`42`	`return *m_in1;`
`43`	`43`	`}`
`@@ -46,7 +46,7 @@ GC::Ref<SVGAnimatedString> SVGFEGaussianBlurElement::in1()`
`46`	`46`	`GC::Ref<SVGAnimatedNumber> SVGFEGaussianBlurElement::std_deviation_x()`
`47`	`47`	`{`
`48`	`48`	`if (!m_std_deviation_x) {`
`49`		`- m_std_deviation_x = SVGAnimatedNumber::create(realm(), *this, AttributeNames::stdDeviation, 0.f,`
	`49`	`+ m_std_deviation_x = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::stdDeviation, OptionalNone {}, OptionalNone {} }, 0.f,`
`50`	`50`	`SVGAnimatedNumber::SupportsSecondValue::Yes, SVGAnimatedNumber::ValueRepresented::First);`
`51`	`51`	`}`
`52`	`52`	`return *m_std_deviation_x;`
`@@ -56,7 +56,7 @@ GC::Ref<SVGAnimatedNumber> SVGFEGaussianBlurElement::std_deviation_x()`
`56`	`56`	`GC::Ref<SVGAnimatedNumber> SVGFEGaussianBlurElement::std_deviation_y()`
`57`	`57`	`{`
`58`	`58`	`if (!m_std_deviation_y) {`
`59`		`- m_std_deviation_y = SVGAnimatedNumber::create(realm(), *this, AttributeNames::stdDeviation, 0.f,`
	`59`	`+ m_std_deviation_y = SVGAnimatedNumber::create(realm(), *this, DOM::QualifiedName { AttributeNames::stdDeviation, OptionalNone {}, OptionalNone {} }, 0.f,`
`60`	`60`	`SVGAnimatedNumber::SupportsSecondValue::Yes, SVGAnimatedNumber::ValueRepresented::Second);`
`61`	`61`	`}`
`62`	`62`	`return *m_std_deviation_y;`