LibCore: Fix ThreadedPromise issues found with ThreadSanitizer

rcorsi · Zaggy1024 · commit 892e75ddfbdf · 2025-09-24T21:05:54.000-05:00
diff --git a/Libraries/LibCore/ThreadedPromise.h b/Libraries/LibCore/ThreadedPromise.h
@@ -61,7 +61,6 @@ class ThreadedPromise
 
     bool has_completed()
     {
-        Threading::MutexLocker locker { m_mutex };
         return m_has_completed;
     }
 
@@ -183,7 +182,7 @@ class ThreadedPromise
     Function<ErrorOr<void>(ResultType&&)> m_resolution_handler;
     Function<void(ErrorType&&)> m_rejection_handler;
     Threading::Mutex m_mutex;
-    bool m_has_completed;
+    Atomic<bool> m_has_completed;
 };
 
 }
diff --git a/Tests/LibCore/TestLibCorePromise.cpp b/Tests/LibCore/TestLibCorePromise.cpp
@@ -158,7 +158,7 @@ TEST_CASE(threaded_promise_resolved_later)
 {
     Core::EventLoop loop;
 
-    IGNORE_USE_IN_ESCAPING_LAMBDA bool unblock_thread = false;
+    IGNORE_USE_IN_ESCAPING_LAMBDA Atomic<bool> unblock_thread = false;
     bool resolved = false;
     bool rejected = true;
     Optional<pthread_t> thread_id;

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ class ThreadedPromise`
`61`	`61`
`62`	`62`	`bool has_completed()`
`63`	`63`	`{`
`64`		`- Threading::MutexLocker locker { m_mutex };`
`65`	`64`	`return m_has_completed;`
`66`	`65`	`}`
`67`	`66`
`@@ -183,7 +182,7 @@ class ThreadedPromise`
`183`	`182`	`Function<ErrorOr<void>(ResultType&&)> m_resolution_handler;`
`184`	`183`	`Function<void(ErrorType&&)> m_rejection_handler;`
`185`	`184`	`Threading::Mutex m_mutex;`
`186`		`- bool m_has_completed;`
	`185`	`+ Atomic<bool> m_has_completed;`
`187`	`186`	`};`
`188`	`187`
`189`	`188`	`}`
Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ TEST_CASE(threaded_promise_resolved_later)`
`158`	`158`	`{`
`159`	`159`	`Core::EventLoop loop;`
`160`	`160`
`161`		`- IGNORE_USE_IN_ESCAPING_LAMBDA bool unblock_thread = false;`
	`161`	`+ IGNORE_USE_IN_ESCAPING_LAMBDA Atomic<bool> unblock_thread = false;`
`162`	`162`	`bool resolved = false;`
`163`	`163`	`bool rejected = true;`
`164`	`164`	`Optional<pthread_t> thread_id;`