Skip to content

Commit a853bb4

Browse files
trflynn89gmta
authored andcommitted
LibWebView+UI: Pass RequestServerOptions to Application implementations
This will be needed by test-web.
1 parent 0020af3 commit a853bb4

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

Libraries/LibWebView/Application.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ ErrorOr<void> Application::initialize(Main::Arguments const& arguments)
283283
.default_time_zone = default_time_zone,
284284
};
285285

286-
create_platform_options(m_browser_options, m_web_content_options);
286+
create_platform_options(m_browser_options, m_request_server_options, m_web_content_options);
287287
initialize_actions();
288288

289289
m_event_loop = create_platform_event_loop();

Libraries/LibWebView/Application.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ class WEBVIEW_API Application : public DevTools::DevToolsDelegate {
139139
virtual void process_did_exit(Process&&);
140140

141141
virtual void create_platform_arguments(Core::ArgsParser&) { }
142-
virtual void create_platform_options(BrowserOptions&, WebContentOptions&) { }
142+
virtual void create_platform_options(BrowserOptions&, RequestServerOptions&, WebContentOptions&) { }
143143
virtual NonnullOwnPtr<Core::EventLoop> create_platform_event_loop();
144144

145145
virtual Optional<ByteString> ask_user_for_download_folder() const { return {}; }

Tests/LibWeb/test-web/Application.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ void Application::create_platform_arguments(Core::ArgsParser& args_parser)
5757
});
5858
}
5959

60-
void Application::create_platform_options(WebView::BrowserOptions& browser_options, WebView::WebContentOptions& web_content_options)
60+
void Application::create_platform_options(WebView::BrowserOptions& browser_options, WebView::RequestServerOptions&, WebView::WebContentOptions& web_content_options)
6161
{
6262
browser_options.headless_mode = WebView::HeadlessMode::Test;
6363
browser_options.disable_sql_database = WebView::DisableSQLDatabase::Yes;

Tests/LibWeb/test-web/Application.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class Application : public WebView::Application {
2121
~Application();
2222

2323
virtual void create_platform_arguments(Core::ArgsParser&) override;
24-
virtual void create_platform_options(WebView::BrowserOptions&, WebView::WebContentOptions&) override;
24+
virtual void create_platform_options(WebView::BrowserOptions&, WebView::RequestServerOptions&, WebView::WebContentOptions&) override;
2525

2626
ErrorOr<void> launch_test_fixtures();
2727

UI/Qt/Application.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class LadybirdQApplication : public QApplication {
9494
Application::Application() = default;
9595
Application::~Application() = default;
9696

97-
void Application::create_platform_options(WebView::BrowserOptions&, WebView::WebContentOptions& web_content_options)
97+
void Application::create_platform_options(WebView::BrowserOptions&, WebView::RequestServerOptions&, WebView::WebContentOptions& web_content_options)
9898
{
9999
web_content_options.config_path = Settings::the()->directory();
100100
}

UI/Qt/Application.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class Application : public WebView::Application {
3333
private:
3434
explicit Application();
3535

36-
virtual void create_platform_options(WebView::BrowserOptions&, WebView::WebContentOptions&) override;
36+
virtual void create_platform_options(WebView::BrowserOptions&, WebView::RequestServerOptions&, WebView::WebContentOptions&) override;
3737
virtual NonnullOwnPtr<Core::EventLoop> create_platform_event_loop() override;
3838

3939
virtual Optional<WebView::ViewImplementation&> active_web_view() const override;

0 commit comments

Comments
 (0)