Fix for select2 dropdownParent inside inline create modals #3876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: No new issues |
tabacitu
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
I'm not "happy" about all the conditionals but... if it's what we've got to do... we've got to do it. The code is clean, nothing to improve in my opinion, just... not ideal, you know? 😅
@promatik could you please thoroughly test this and give the final thumbs-up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3838
As described in the issue thread there is a problem introduced by jQuery I think that affects the select2 in some breaking way.
The problem is that the dropdown does not work inside inline create modals unless the correct parent is specified on the select2 initialization.
Note: this will probably be fixed in some future version of select2/jquery, or we migth take other direction that does not rely on this dependencies.
@tabacitu can you please take a look at this and give it a try in your browsers ? I tested in latest chrome for win.
Best,
Pedro