fix(H-1): correct array indexing for BN254TableCalculatorBase._calculateOperatorTable #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadir-akhtar
force-pushed
the
nadir/bn254-table-calculator-base-fix
branch
from
5288a6b to
90a8d18
Compare
ypatil12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As discovered during audit,
BN254TableCalculatorBase._calculateOperatorTableincorrectly usesifor the index when collecting registered operators rather thanoperatorCount, leading to malformed arrays. The corresponding test intended to validate this behavior but failed to.Modifications:
Result:
Auditing finding addressed, correct code and tests