fix: multichain pt1 audit fixes #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
force-pushed
the
release-dev/multichain-audit-fixes
branch
2 times, most recently
from
2b51e9b to
f32dc54
Compare
**Motivation:** Middleware contains tons of unused imports, which reduces code clarity. **Modifications:** - Used `forge lint src --only-lint unused-import` to remove all unused imports from `src`. **Result:** Improved clarity.
**Motivation:** We now have two `ISocketRegistry` interfaces, and need to differentiate for clarity. **Modifications:** - Renamed **new** `ISocketRegistry` -> `ISocketRegistryV2` **Result:** Improved clarity.
**Motivation:** If the `weights` array has a different length or stake composition, cert verification would silently fail. There is no way to enforce this for BN254. To opt for similar behavior, we clarify this in our natspec. **Modifications:** Update natspec/docs on risks of different array lengths. **Result:** Clearer code --------- Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
**Motivation:** Update incorrect natspec **Modifications:** - Clarify `KeyRegistrar` usage - Clarify `calculateOperatorTable` usage **Result:** Clearer natspec
**Motivation:** The following natspec is present but isn't true and suggest improper use. ```solidity /// @dev The immutable avs address `AVSRegistrar` is NOT the address of the AVS in EigenLayer core. /// @dev The address of the AVS in EigenLayer core is the proxy contract, and it is set via the `initialize` function below. ``` **Modifications:** - Removed confusing comments - Made AVS var stateful and `AVSRegistrar` abstract **Result:** Improved clarity.
ypatil12
force-pushed
the
release-dev/multichain-audit-fixes
branch
from
ec35d75 to
f3580bd
Compare
0xrajath
reviewed
Jul 31, 2025
0xrajath
reviewed
Jul 31, 2025
| import {IAVSRegistrar} from "eigenlayer-contracts/src/contracts/interfaces/IAVSRegistrar.sol"; | ||
| import {IAVSRegistrarInternal} from "./IAVSRegistrarInternal.sol"; | ||
| import {ISocketRegistry} from "./ISocketRegistryV2.sol"; | ||
| import {ISocketRegistryV2} from "./ISocketRegistryV2.sol"; |
There was a problem hiding this comment.
Is this the latest interface?
chore: update test
0xrajath
reviewed
Jul 31, 2025
There was a problem hiding this comment.
Is this the latest changes from main on eigenlayer-contracts?
There was a problem hiding this comment.
Latest changes from the corresponding contracts PR
There was a problem hiding this comment.
Should that be merged first before this is merged?
There was a problem hiding this comment.
Should be fine since that will be latest commit (soon)
ypatil12
force-pushed
the
release-dev/multichain-audit-fixes
branch
from
4db21e4 to
a6806d4
Compare
0xrajath
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multichain pt1. Audit Fixes:
High:
Informational:
ISocketRegistry->ISocketRegistryV2#511weightsarray structure #510