fix(I-07): clarify expectation on weights array structure
#510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
force-pushed
the
docs/document-diff-array-lengths
branch
from
5a70c22 to
5f6006c
Compare
nadir-akhtar
approved these changes
Jul 26, 2025
eigenmikem
approved these changes
Jul 28, 2025
ypatil12
added a commit
that referenced
this pull request
Jul 29, 2025
**Motivation:** If the `weights` array has a different length or stake composition, cert verification would silently fail. There is no way to enforce this for BN254. To opt for similar behavior, we clarify this in our natspec. **Modifications:** Update natspec/docs on risks of different array lengths. **Result:** Clearer code --------- Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
ypatil12
added a commit
that referenced
this pull request
Jul 31, 2025
**Motivation:** If the `weights` array has a different length or stake composition, cert verification would silently fail. There is no way to enforce this for BN254. To opt for similar behavior, we clarify this in our natspec. **Modifications:** Update natspec/docs on risks of different array lengths. **Result:** Clearer code --------- Co-authored-by: Nadir Akhtar <nadir-akhtar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If the
weightsarray has a different length or stake composition, cert verification would silently fail. There is no way to enforce this for BN254. To opt for similar behavior, we clarify this in our natspec.Modifications:
Update natspec/docs on risks of different array lengths.
Result:
Clearer code