fix(I-04): make avs var stateful & remove confusing natspec #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
requested changes
Jul 24, 2025
ypatil12
reviewed
Jul 24, 2025
src/middlewareV2/registrar/presets/AVSRegistrarAsIdentifier.sol
Outdated
Show resolved
Hide resolved
0xClandestine
force-pushed
the
fix/remove-confusing-natspec
branch
from
2aab0c0 to
5bc1af5
Compare
0xClandestine
force-pushed
the
fix/remove-confusing-natspec
branch
from
f01a098 to
f6d1eef
Compare
|
storage test failing because avs is now mutable |
ypatil12
approved these changes
Jul 28, 2025
ypatil12
changed the title
ypatil12
merged commit 56530c4
into
release-dev/multichain-audit-fixes
8 of 9 checks passed
ypatil12
pushed a commit
that referenced
this pull request
Jul 29, 2025
**Motivation:** The following natspec is present but isn't true and suggest improper use. ```solidity /// @dev The immutable avs address `AVSRegistrar` is NOT the address of the AVS in EigenLayer core. /// @dev The address of the AVS in EigenLayer core is the proxy contract, and it is set via the `initialize` function below. ``` **Modifications:** - Removed confusing comments - Made AVS var stateful and `AVSRegistrar` abstract **Result:** Improved clarity.
ypatil12
pushed a commit
that referenced
this pull request
Jul 29, 2025
**Motivation:** The following natspec is present but isn't true and suggest improper use. ```solidity /// @dev The immutable avs address `AVSRegistrar` is NOT the address of the AVS in EigenLayer core. /// @dev The address of the AVS in EigenLayer core is the proxy contract, and it is set via the `initialize` function below. ``` **Modifications:** - Removed confusing comments - Made AVS var stateful and `AVSRegistrar` abstract **Result:** Improved clarity.
ypatil12
pushed a commit
that referenced
this pull request
Jul 31, 2025
**Motivation:** The following natspec is present but isn't true and suggest improper use. ```solidity /// @dev The immutable avs address `AVSRegistrar` is NOT the address of the AVS in EigenLayer core. /// @dev The address of the AVS in EigenLayer core is the proxy contract, and it is set via the `initialize` function below. ``` **Modifications:** - Removed confusing comments - Made AVS var stateful and `AVSRegistrar` abstract **Result:** Improved clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The following natspec is present but isn't true and suggest improper use.
Modifications:
AVSRegistrarabstractResult:
Improved clarity.