feat(manifest): fixing pr comments

Author: milos1290

AndroidSDK/src/com/leanplum/LeanplumFcmProvider.java

@@ -53,21 +53,17 @@ public boolean isManifestSetup() {
     if (context == null) {
       return false;
     }
-
-    if (!BuildConfig.DEBUG) {
-      return true;
-    }
     // Firebase can only be setup through gradle, so we don't have to check manually
     // whether manifest is properly setup. We will only check our own services.
     try {
       boolean hasPushFirebaseMessagingService = LeanplumManifestHelper.checkComponent(
           LeanplumManifestHelper.ApplicationComponent.SERVICE,
-          LeanplumPushFirebaseMessagingService.class.getName(), false, null,
+          LeanplumManifestHelper.PUSH_FIREBASE_MESSAGING_SERVICE, false, null,
           Collections.singletonList(LeanplumManifestHelper.MESSAGING_EVENT), context.getPackageName());
 
       boolean hasPushFirebaseListenerService = LeanplumManifestHelper.checkComponent(
           LeanplumManifestHelper.ApplicationComponent.SERVICE,
-          LeanplumPushFcmListenerService.class.getName(), false, null,
+          LeanplumManifestHelper.PUSH_FCM_LISTENER_SERVICE, false, null,
           Collections.singletonList(LeanplumManifestHelper.INSTANCE_ID_EVENT), context.getPackageName());
 
       boolean hasRegistrationService = LeanplumManifestHelper.checkComponent(
@@ -82,7 +78,7 @@ public boolean isManifestSetup() {
       Util.handleException(t);
     }
     Log.e("Failed to setup Firebase Messaging, check your manifest configuration.");
-    return true;
+    return false;
   }
 
   @Override

AndroidSDK/src/com/leanplum/LeanplumGcmProvider.java

@@ -49,15 +49,15 @@ class LeanplumGcmProvider extends LeanplumCloudMessagingProvider {
 
   private static String senderIds;
 
+  /**
+   * Sets GCM sender id.
+   *
+   * @param senderId Sender id.
+   */
   static void setSenderId(String senderId) {
     senderIds = senderId;
   }
 
-  /**
-   * Stores the GCM sender ID in the application's {@code SharedPreferences}.
-   *
-   * @param context application's context.
-   */
   @Override
   public void storePreferences(Context context) {
     super.storePreferences(context);
@@ -119,10 +119,6 @@ public boolean isManifestSetup() {
     if (context == null) {
       return false;
     }
-    // We don't want to check if manifest is setup in Release build.
-    if (!BuildConfig.DEBUG) {
-      return true;
-    }
     try {
       boolean hasPermissions = LeanplumManifestHelper.checkPermission(LeanplumManifestHelper.RECEIVE_PERMISSION, false, true)
           && (LeanplumManifestHelper.checkPermission(context.getPackageName() + ".gcm.permission.C2D_MESSAGE", true, false)

AndroidSDK/src/com/leanplum/internal/LeanplumManifestHelper.java

@@ -55,6 +55,8 @@ public class LeanplumManifestHelper {
 
   // Leanplum
   public static final String PUSH_LISTENER_SERVICE_FILTER = "com.leanplum.LeanplumPushListenerService";
+  public static final String PUSH_FCM_LISTENER_SERVICE = "com.leanplum.LeanplumPushFcmListenerService";
+  public static final String PUSH_FIREBASE_MESSAGING_SERVICE = "com.leanplum.LeanplumPushFirebaseMessagingService";
 
   /**
    * Gets Class for name.