feat(notifications): using action without package name

Author: milos1290

AndroidSDK/src/com/leanplum/LeanplumPushReceiver.java

@@ -56,9 +56,7 @@ public void onReceive(Context context, Intent intent) {
         // Forward Intent to a client broadcast receiver.
         Intent forwardIntent = new Intent();
         // Add action to be able to differentiate between multiple intents.
-        String action = Util.buildIntentAction(context,
-            Constants.ClassUtil.LEANPLUM_NOTIFICATION);
-        forwardIntent.setAction(action);
+        forwardIntent.setAction(LeanplumPushService.LEANPLUM_NOTIFICATION);
         forwardIntent.setClassName(context, receiver);
         forwardIntent.putExtras(intent.getExtras());
         context.sendBroadcast(forwardIntent);

AndroidSDK/src/com/leanplum/LeanplumPushService.java

@@ -71,7 +71,10 @@ public class LeanplumPushService {
    * Leanplum's built-in Google Cloud Messaging sender ID.
    */
   public static final String LEANPLUM_SENDER_ID = "44059457771";
-
+  /**
+   * Intent action used when broadcast is received in custom BroadcastReceiver.
+   */
+  public static final String LEANPLUM_NOTIFICATION = "LP_NOTIFICATION";
   /**
    * Action param key contained when Notification Bundle is parsed with {@link
    * LeanplumPushService#parseNotificationBundle(Bundle)}.

AndroidSDK/src/com/leanplum/internal/Constants.java

@@ -259,6 +259,5 @@ public static class Messaging {
 
   public static class ClassUtil {
     public static final String UI_INTERFACE_EDITOR = "com.leanplum.uieditor.LeanplumUIEditor";
-    public static final String LEANPLUM_NOTIFICATION = "LP_NOTIFICATION";
   }
 }

AndroidSDK/src/com/leanplum/internal/LeanplumManifestHelper.java

@@ -28,6 +28,7 @@
 import android.text.TextUtils;
 
 import com.leanplum.Leanplum;
+import com.leanplum.LeanplumPushService;
 
 import org.w3c.dom.Document;
 import org.w3c.dom.NamedNodeMap;
@@ -531,7 +532,7 @@ public static String parseNotificationMetadata() {
       ApplicationInfo app = context.getPackageManager().getApplicationInfo(context.getPackageName(),
           PackageManager.GET_META_DATA);
       Bundle bundle = app.metaData;
-      return bundle.getString(Constants.ClassUtil.LEANPLUM_NOTIFICATION);
+      return bundle.getString(LeanplumPushService.LEANPLUM_NOTIFICATION);
     } catch (Throwable ignored) {
     }
     return null;

AndroidSDK/src/com/leanplum/internal/Util.java

@@ -969,18 +969,4 @@ public static int generateIdFromResourceName(String resourceName) {
     Log.w("Could not extract resource id from provided resource name: ", resourceName);
     return 0;
   }
-
-  /**
-   * Builds intent action in format PackageName + Action.
-   *
-   * @param context Surrounding context.
-   * @param action Intent action.
-   * @return Action in format com.example.Action.
-   */
-  public static String buildIntentAction(Context context, String action) {
-    if (context == null) {
-      return null;
-    }
-    return context.getPackageName() + "." + action;
-  }
 }