Skip to content

Commit 5505015

Browse files
committed
fix(assets): adding leanplum branding assets
1 parent 365f4ca commit 5505015

File tree

13 files changed

+17
-18
lines changed

13 files changed

+17
-18
lines changed

AndroidSDKTests/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,4 @@ dependencies {
3838
testCompile 'org.powermock:powermock-api-mockito:1.6.6'
3939
testCompile 'org.powermock:powermock-classloading-xstream:1.6.6'
4040
testCompile 'org.bouncycastle:bcmail-jdk15on:1.54'
41-
}
41+
}
-898 Bytes
Binary file not shown.
20.6 KB
Loading
-10.2 KB
Binary file not shown.
20.6 KB
Loading
-10.2 KB
Binary file not shown.
20.6 KB
Loading

AndroidSDKTests/src/test/java/com/leanplum/LeanplumTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -751,7 +751,7 @@ public void testActions() throws Exception {
751751
args.with(integerArgumentName, 5);
752752
args.with(stringArgumentName, "test_string");
753753
args.with(boolArgumentName, true);
754-
args.withAsset(fileArgumentName, "Mario.png");
754+
args.withAsset(fileArgumentName, "leanplum_watermark.jpg");
755755
args.with(dictionaryArgumentName, CollectionUtil.newHashMap(
756756
"test_value", "test"
757757
));
@@ -797,7 +797,7 @@ public void onRequest(String httpMethod, String apiMethod, Map<String, Object> p
797797
assertNotNull(values.get(arrayArgumentName));
798798
assertEquals("action_test", values.get(actionArgumentName));
799799
assertEquals(Color.BLUE, values.get(colorArgumentName));
800-
assertEquals("Mario.png", values.get(fileArgumentName));
800+
assertEquals("leanplum_watermark.jpg", values.get(fileArgumentName));
801801
}
802802
});
803803
// Define action.

AndroidSDKTests/src/test/java/com/leanplum/__setup/LeanplumTestRunner.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,11 @@ protected AndroidManifest getAppManifest(Config config) {
5050
}
5151

5252
final String type = getType(config);
53-
final String flavor = "sources";
5453
final String packageName = "com.leanplum.tests";
5554

56-
final FileFsFile res = FileFsFile.from(BUILD_OUTPUT, "res", "merged", flavor, type);
55+
final FileFsFile res = FileFsFile.from(BUILD_OUTPUT, "res", "merged", type);
5756
final FileFsFile assets = FileFsFile.from("src", "test", "assets");
58-
final FileFsFile manifest = FileFsFile.from(BUILD_OUTPUT, "manifests", "full", flavor, type,
57+
final FileFsFile manifest = FileFsFile.from(BUILD_OUTPUT, "manifests", "full", type,
5958
"AndroidManifest.xml");
6059

6160
Logger.debug("Robolectric assets directory: " + assets.getPath());

AndroidSDKTests/src/test/java/com/leanplum/_whitebox/UtilitiesTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,10 @@ public void testResourceNameGeneration() throws Exception {
133133
String invalidName = Util.generateResourceNameFromId(invalidResourceId);
134134
assertNull(invalidName);
135135

136-
int validResourceId = com.leanplum.tests.R.drawable.jinja;
136+
int validResourceId = R.drawable.leanplum_watermark;
137137
String validName = Util.generateResourceNameFromId(validResourceId);
138138
assertNotNull(validName);
139-
assertEquals("drawable/jinja.png", validName);
139+
assertEquals("drawable/leanplum_watermark.jpg", validName);
140140
}
141141

142142
@Test
@@ -145,13 +145,13 @@ public void testResourceIdGeneration() throws Exception {
145145
int invalidResourceId = Util.generateIdFromResourceName(invalidName);
146146
assertEquals(0, invalidResourceId);
147147

148-
String validName = "drawable/jinja.png";
148+
String validName = "drawable/leanplum_watermark.jpg";
149149
int validResourceId = Util.generateIdFromResourceName(validName);
150-
assertEquals(R.drawable.jinja, validResourceId);
150+
assertEquals(R.drawable.leanplum_watermark, validResourceId);
151151

152152
// Generated name can be without extension.
153-
String validNameWithoutExtension = "drawable/jinja";
153+
String validNameWithoutExtension = "drawable/leanplum_watermark";
154154
validResourceId = Util.generateIdFromResourceName(validNameWithoutExtension);
155-
assertEquals(R.drawable.jinja, validResourceId);
155+
assertEquals(R.drawable.leanplum_watermark, validResourceId);
156156
}
157157
}

0 commit comments

Comments
 (0)