fix(icon): App icon logic may run in background inside unit test (#84) LP-6272

Author: alexisoyama

Example/Tests/Classes/ActionManagerTest.m

@@ -149,18 +149,6 @@ - (void)test_matched_trigger
 
 - (void)test_require_message_content
 {
-    // This stub have to be removed when start command is successfully executed.
-    [OHHTTPStubs stubRequestsPassingTest:
-     ^BOOL(NSURLRequest * _Nonnull request) {
-         return [request.URL.host isEqualToString:API_HOST];
-     } withStubResponse:^OHHTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
-         NSString *response_file = OHPathForFile(@"simple_start_response.json", self.class);
-         return [OHHTTPStubsResponse responseWithFileAtPath:response_file statusCode:200
-                                                    headers:@{@"Content-Type":@"application/json"}];
-     }];
-    
-    XCTAssertTrue([LeanplumHelper start_development_test]);
-    
     // Vaidate request.
     [LeanplumRequest validate_request:^(NSString *method, NSString *apiMethod,
                                         NSDictionary *params) {
@@ -192,18 +180,6 @@ - (void)test_notification_action
 
 - (void) test_receive_notification
 {
-    // This stub have to be removed when start command is successfully executed.
-    [OHHTTPStubs stubRequestsPassingTest:
-     ^BOOL(NSURLRequest * _Nonnull request) {
-         return [request.URL.host isEqualToString:API_HOST];
-     } withStubResponse:^OHHTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
-         NSString *response_file = OHPathForFile(@"simple_start_response.json", self.class);
-         return [OHHTTPStubsResponse responseWithFileAtPath:response_file statusCode:200
-                                                    headers:@{@"Content-Type":@"application/json"}];
-     }];
-    
-    XCTAssertTrue([LeanplumHelper start_development_test]);
-    
     NSDictionary* userInfo = @{
                                @"_lpm": @"messageId",
                                @"_lpx": @"test_action",

Example/Tests/Classes/EventDataManagerTest.m

@@ -90,11 +90,6 @@ - (void)test_migrateRequests
     [[LeanplumRequest sendNowQueue] cancelAllOperations];
     [[LeanplumRequest sendNowQueue] waitUntilAllOperationsAreFinished];
 
-    NSFileManager *fileManager = [NSFileManager defaultManager];
-    if ([fileManager fileExistsAtPath:[LPDatabase sqliteFilePath]]) {
-        [fileManager removeItemAtPath:[LPDatabase sqliteFilePath] error:nil];
-    }
-    
     [LPEventDataManager deleteEventsWithLimit:10000];
 
     [[LPRequestStorage sharedStorage] popAllRequests];

Example/Tests/Classes/LeanplumTest.m

@@ -136,7 +136,6 @@ - (void) test_simple_production_start
         NSString* deviceModel = params[@"deviceModel"];
         XCTAssertTrue([deviceModel isEqualToString:@"iPhone"] ||
                       [deviceModel isEqualToString:@"iPhone Simulator"]);
-        XCTAssertTrue([params[@"deviceName"] isEqualToString:[[UIDevice currentDevice] name]]);
         XCTAssertEqualObjects(@0, params[@"includeDefaults"]);
         XCTAssertNotNil(params[@"locale"]);
         XCTAssertNotNil(params[@"timezone"]);
@@ -245,7 +244,6 @@ - (void) test_complex_production_start
         NSString* deviceModel = params[@"deviceModel"];
         XCTAssertTrue([deviceModel isEqualToString:@"iPhone"] ||
                       [deviceModel isEqualToString:@"iPhone Simulator"]);
-        XCTAssertTrue([params[@"deviceName"] isEqualToString:[[UIDevice currentDevice] name]]);
         XCTAssertEqualObjects(@0, params[@"includeDefaults"]);
         XCTAssertNotNil(params[@"locale"]);
         XCTAssertNotNil(params[@"timezone"]);

Example/Tests/Classes/Utilities/LeanplumHelper.m

@@ -129,6 +129,7 @@ + (void)clean_up {
     [LeanplumRequest reset];
     [LeanplumHelper reset_user_defaults];
     [[LeanplumRequest sendNowQueue] cancelAllOperations];
+    [[LeanplumRequest sendNowQueue] waitUntilAllOperationsAreFinished];
 }
 
 + (dispatch_time_t)default_dispatch_time {

Leanplum-SDK/Classes/LPAppIconManager.m

@@ -82,6 +82,18 @@ + (void)uploadAppIconsOnDevMode
  */
 + (BOOL)supportsAlternateIcons
 {
+    // Run on main thread.
+    if (![NSThread isMainThread]) {
+        BOOL __block outputValue = NO;
+        dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);
+        dispatch_async(dispatch_get_main_queue(), ^{
+            outputValue = [self supportsAlternateIcons];
+            dispatch_semaphore_signal(semaphore);
+        });
+        dispatch_semaphore_wait(semaphore, 0.01*NSEC_PER_SEC);
+        return outputValue;
+    }
+    
     UIApplication *app = [UIApplication sharedApplication];
     if ([app respondsToSelector:@selector(supportsAlternateIcons)]) {
         return [app supportsAlternateIcons];

Leanplum-SDK/Classes/LPMessageTemplates.m

@@ -322,7 +322,9 @@ - (void)defineActions
              withArguments:@[[LPActionArg argNamed:LPMT_ARG_URL withString:LPMT_DEFAULT_URL]]
              withResponder:^BOOL(LPActionContext *context) {
                  @try {
-                     [[UIApplication sharedApplication] openURL:[NSURL URLWithString:[context stringNamed:LPMT_ARG_URL]]];
+                     dispatch_async(dispatch_get_main_queue(), ^{
+                         [[UIApplication sharedApplication] openURL:[NSURL URLWithString:[context stringNamed:LPMT_ARG_URL]]];
+                     });
                      return YES;
                  }
                  @catch (NSException *exception) {
@@ -835,6 +837,15 @@ - (void)deferPush
 
 - (BOOL)isPushEnabled
 {
+    // Run on main thread.
+    if (![NSThread isMainThread]) {
+        BOOL __block output = NO;
+        dispatch_sync(dispatch_get_main_queue(), ^{
+            output = [self isPushEnabled];
+        });
+        return output;
+    }
+    
     UIApplication *application = [UIApplication sharedApplication];
     BOOL enabled;
 
@@ -1204,9 +1215,11 @@ - (void)refreshPopupContent
 
 - (void)appStorePrompt
 {
-    if (NSClassFromString(@"SKStoreReviewController")) {
-        [SKStoreReviewController requestReview];
-    }
+    dispatch_async(dispatch_get_main_queue(), ^{
+        if (NSClassFromString(@"SKStoreReviewController")) {
+            [SKStoreReviewController requestReview];
+        }
+    });
 }
 
 - (BOOL)hasAlternateIcon
@@ -1218,6 +1231,13 @@ - (BOOL)hasAlternateIcon
 
 - (void)setAlternateIconWithFilename:(NSString *)filename
 {
+    if (![NSThread isMainThread]) {
+        dispatch_sync(dispatch_get_main_queue(), ^{
+            [self setAlternateIconWithFilename:filename];
+            return;
+        });
+    }
+    
     NSString *iconName = [filename stringByReplacingOccurrencesOfString:LPMT_ICON_FILE_PREFIX
                                                              withString:@""];
     iconName = [iconName stringByReplacingOccurrencesOfString:@".png" withString:@""];