fix(request): Removed lock from loadRequests and add additional protection for 500

Author: Alexis Oyama

Leanplum-SDK/Classes/LPRequestStorage.m

@@ -124,22 +124,20 @@ - (void)saveRequests:(NSMutableArray *)requests
  */
 - (NSMutableArray *)loadRequests
 {
-    @synchronized (self) {
-        NSData *requestData = [NSData dataWithContentsOfFile:self.documentsFilePath];
-        if (requestData) {
-            NSError *error = nil;
-            NSMutableArray *requests = [NSPropertyListSerialization
-                                             propertyListWithData:requestData
-                                             options:NSPropertyListMutableContainers
-                                             format:NULL error:&error];
-            if (error) {
-                LPLog(LPDebug, @"Error in loading requets: %@", error);
-            } else {
-                LPLog(LPDebug, @"Loaded %lu requests", (unsigned long) requests.count);
-            }
-            
-            return requests;
+    NSData *requestData = [NSData dataWithContentsOfFile:self.documentsFilePath];
+    if (requestData) {
+        NSError *error = nil;
+        NSMutableArray *requests = [NSPropertyListSerialization
+                                         propertyListWithData:requestData
+                                         options:NSPropertyListMutableContainers
+                                         format:NULL error:&error];
+        if (error) {
+            LPLog(LPDebug, @"Error in loading requets: %@", error);
+        } else {
+            LPLog(LPDebug, @"Loaded %lu requests", (unsigned long) requests.count);
         }
+        
+        return requests;
     }
 
     return [NSMutableArray new];

Leanplum-SDK/Classes/LeanplumRequest.m

@@ -369,10 +369,11 @@ - (void)sendNow:(BOOL)async
         NSInteger httpStatusCode = completedOperation.HTTPStatusCode;
         if (httpStatusCode == 408
             || (httpStatusCode >= 500 && httpStatusCode < 600)
-            || err.code == kCFURLErrorCannotConnectToHost
-            || err.code == kCFURLErrorDNSLookupFailed
-            || err.code == kCFURLErrorNotConnectedToInternet
-            || err.code == kCFURLErrorTimedOut) {
+            || err.code == NSURLErrorBadServerResponse
+            || err.code == NSURLErrorCannotConnectToHost
+            || err.code == NSURLErrorDNSLookupFailed
+            || err.code == NSURLErrorNotConnectedToInternet
+            || err.code == NSURLErrorTimedOut) {
             NSLog(@"Leanplum: %@", err);
             [LeanplumRequest pushUnsentRequests:requestsToSend];
         } else {