perf(ActionManager): Send push token in start and when token changed

SDK will no longer have data loss so it is not needed to send on every launch.

Author: Alexis Oyama

Leanplum-SDK/Classes/LPActionManager.m

@@ -48,13 +48,6 @@ LeanplumMessageMatchResult LeanplumMessageMatchResultMake(BOOL matchedTrigger, B
 
 @implementation NSObject (LeanplumExtension)
 
-- (NSString *)leanplum_createTokenKey
-{
-    return [NSString stringWithFormat:
-            LEANPLUM_DEFAULTS_PUSH_TOKEN_KEY,
-            LeanplumRequest.appId, LeanplumRequest.userId, LeanplumRequest.deviceId];
-}
-
 - (void)leanplum_disableAskToAsk
 {
 #if LP_NOT_TV
@@ -77,26 +70,24 @@ - (void)leanplum_application:(UIApplication *)application didRegisterForRemoteNo
         [self leanplum_disableAskToAsk];
     }
 
-    // Send push token on every launch. This is required because push token may not be sent if the
-    // user force quit the app. This is due to how LPRequestStorage keeps the data in memory and
-    // we don't support response block on batch.
+    // Format push token.
     NSString *formattedToken = [deviceToken description];
     formattedToken = [[[formattedToken stringByReplacingOccurrencesOfString:@"<" withString:@""]
                        stringByReplacingOccurrencesOfString:@">" withString:@""]
                       stringByReplacingOccurrencesOfString:@" " withString:@""];
-    [Leanplum onStartResponse:^(BOOL success) {
-        LP_END_USER_CODE
-        [[LeanplumRequest post:LP_METHOD_SET_DEVICE_ATTRIBUTES
-                        params:@{LP_PARAM_DEVICE_PUSH_TOKEN: formattedToken}] send];
-        LP_BEGIN_USER_CODE
-    }];
 
-    // Update push token if it's different.
-    NSString *tokenKey = [self leanplum_createTokenKey];
+    // Send push token if we don't have one and when the token changed.
+    // We no longer send in start's response because saved push token will be send in start too.
+    NSString *tokenKey = [Leanplum pushTokenKey];
     NSString *existingToken = [[NSUserDefaults standardUserDefaults] stringForKey:tokenKey];
-    if (![existingToken isEqualToString: formattedToken]) {
-        [[NSUserDefaults standardUserDefaults] setObject: formattedToken forKey:tokenKey];
+    if (!existingToken || ![existingToken isEqualToString:formattedToken]) {
+        [[NSUserDefaults standardUserDefaults] setObject:formattedToken forKey:tokenKey];
         [[NSUserDefaults standardUserDefaults] synchronize];
+        
+        if ([Leanplum hasStarted]) {
+            [[LeanplumRequest post:LP_METHOD_SET_DEVICE_ATTRIBUTES
+                            params:@{LP_PARAM_DEVICE_PUSH_TOKEN: formattedToken}] send];
+        }
     }
     LP_END_TRY
 
@@ -140,7 +131,7 @@ - (void)leanplum_application:(UIApplication *)application didFailToRegisterForRe
 {
     LP_TRY
     [self leanplum_disableAskToAsk];
-    NSString *tokenKey = [self leanplum_createTokenKey];
+    NSString *tokenKey = [Leanplum pushTokenKey];
     if ([[NSUserDefaults standardUserDefaults] stringForKey:tokenKey]) {
         [[NSUserDefaults standardUserDefaults] removeObjectForKey:tokenKey];
         [[NSUserDefaults standardUserDefaults] synchronize];
@@ -322,7 +313,7 @@ - (void)sendUserNotificationSettingsIfChanged:(UIUserNotificationSettings *)noti
     if (![existingSettings isEqualToDictionary:settings]) {
         [[NSUserDefaults standardUserDefaults] setObject:settings forKey:settingsKey];
         [[NSUserDefaults standardUserDefaults] synchronize];
-        NSString *tokenKey = [self leanplum_createTokenKey];
+        NSString *tokenKey = [Leanplum pushTokenKey];
         NSString *existingToken = [[NSUserDefaults standardUserDefaults] stringForKey:tokenKey];
         NSMutableDictionary *params = [@{
                 LP_PARAM_DEVICE_USER_NOTIFICATION_TYPES: types,

Leanplum-SDK/Classes/Leanplum.m

@@ -424,6 +424,12 @@ + (void)synchronizeDefaults
     });
 }
 
++ (NSString *)pushTokenKey
+{
+    return [NSString stringWithFormat: LEANPLUM_DEFAULTS_PUSH_TOKEN_KEY,
+            LeanplumRequest.appId, LeanplumRequest.userId, LeanplumRequest.deviceId];
+}
+
 + (void)start
 {
     [self startWithUserId:nil userAttributes:nil responseHandler:nil];
@@ -878,6 +884,14 @@ + (void)startWithUserId:(NSString *)userId
 
     // Get the current Inbox messages on the device.
     params[LP_PARAM_INBOX_MESSAGES] = [self.inbox messagesIds];
+    
+    // Push token.
+    NSString *pushTokenKey = [Leanplum pushTokenKey];
+    NSString *pushToken = [[NSUserDefaults standardUserDefaults] stringForKey:pushTokenKey];
+    if (pushToken) {
+        params[LP_PARAM_DEVICE_PUSH_TOKEN] = pushToken;
+    }
+    params[LP_PARAM_DEVICE_PUSH_TOKEN] = @"123";
 
     // Issue start API call.
     LeanplumRequest *req = [LeanplumRequest post:LP_METHOD_START params:params];

Leanplum-SDK/Classes/LeanplumInternal.h

@@ -136,6 +136,11 @@ andParameters:(NSDictionary *)params;
 + (void)onEventsChanged:(LeanplumEventsChangedBlock)block;
 + (void)synchronizeDefaults;
 
+/**
+ * Returns a push token using app ID, device ID, and user ID.
+ */
++ (NSString *)pushTokenKey;
+
 void LPLog(LPLogType type, NSString* format, ...);
 
 @end