Skip to content

Helena Framework 0.21.1-alpha

Pre-release
Pre-release

Choose a tag to compare

@LimeGS LimeGS released this 04 Aug 03:31
· 35 commits to main since this release

A fix release over v0.21.0-alpha. Nothing in the interface changed.

A certified surface's QC job was stranded

enqueue_imported_surface_qc read the geometry verdict from the payload it was handed.
An import's payload never carries one, so it fell back to the unmeasured default and
created the QC job in WAITING_GEOMETRY.

That is the right answer for a surface nobody has measured, and the wrong one for a
surface already certified. The promotion out of waiting runs at certification — so
certifying a surface and then enqueuing its job left the job waiting for a verdict
that had already come and gone. The surface's own row held the answer the whole time.

Both the PostgreSQL and SQLite stores had it, and both are fixed: a verdict already
recorded against the surface now outranks the default.

The same call reported a state it had not written

It answered "qc_state": "PENDING" regardless of what it inserted, so a caller was told
a job was claimable while the row said WAITING_GEOMETRY. It now reports what it wrote.

An assertion one function below already forbade a hardcoded PENDING on this path. It
looked for the single-quoted SQL literal; the value was double-quoted. It had passed for
three commits.

Why now

The database tests had never run — not in this project's CI, not locally — because they
skip without HELENA_TEST_DSN, and nothing set one. Giving them a database ran them for
the first time and five failed. Two were the bugs above. Three were the tests' own: a
helper created a task and then claimed whatever the queue held, which in a shared
database was another test's.

The two new regression tests exercise the store rather than reading its source.


Alpha. 1829 tests, coverage 65%.