Extra headers (including removal of "Origin") and SockJS+STOMP example #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The origin header often makes trouble with current WebSocket implementations. Thus, we introduce the WEBSOCKET_HEADERS_NO_ORIGIN macro which disables this header it if defined.
Links2004
reviewed
Jul 19, 2017
There was a problem hiding this comment.
overall looking fine,
the *.ino code style looks off some how (space/tap).
using a simple string for the header is fine for now,
implementing a linked string list for this looks overkill to me since for the moment it will be mostly not used and makes it unnecessary complex.
src/WebSocketsClient.h
Outdated
| void setAuthorization(const char * auth); | ||
|
|
||
| void setExtraHeaders(const char * extraHeaders = NULL); | ||
| void setExtraHeaders(char * extraHeaders); |
There was a problem hiding this comment.
where is the Implementation of void setExtraHeaders(char * extraHeaders);?
may simple remove it. const char * will work fine for text data.
|
Hi, I fixed the indent (IDE was set to tab size 2) and removed the redundant function specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I had an issue with connecting to a Spring based SockJS+STOMP endpoint. Specifically the default settings of Spring do not allow an "Origin" header which is hardcoded in the current version of the arduinoWebSockets library. Also, there was no example how to handle SockJS+STOMP.
This pull request adds the capability of removing the hardcoded "Origin" header and enables the user to set custom headers. Additionally it provides an example for connecting to a Spring based SockJS+STOMP endpoint.
There are probably ways to do this more elegantly (like using String arrays to specify headers) or efficiently (e.g., using preprocessor statements), but I opted for the fasted way to implement this. Let me know what you think.
This pull request is somewhat related to issues #131 and #182 . If I have missed already existing functionality, please kindly ignore and delete this request 😏