Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found in proposal and stake scripts #200

Merged
merged 9 commits into from
Oct 28, 2022
Merged

Fix issues found in proposal and stake scripts #200

merged 9 commits into from
Oct 28, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Oct 24, 2022 •
edited
Loading

Based on #199. More tests will be added in an upcoming pr.

@chfanghr chfanghr requested a review from emiflake October 24, 2022 10:46
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch from 1d8bf23 to ac505db Compare October 24, 2022 10:50
@chfanghr chfanghr marked this pull request as draft October 24, 2022 11:51
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch from 67e37cf to b144e18 Compare October 24, 2022 15:42
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch 2 times, most recently from 22dd6be to 8c959bc Compare October 25, 2022 11:31
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch 6 times, most recently from 8e885f1 to 25b5958 Compare October 26, 2022 13:30
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch 2 times, most recently from e3f392f to e2adac1 Compare October 26, 2022 16:16
@chfanghr chfanghr changed the title Fix issues found in proposal scripts Fix issues found in proposal and stake scripts Oct 26, 2022
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch 2 times, most recently from 08b6ed0 to 9a63c2a Compare October 27, 2022 11:33
@chfanghr chfanghr marked this pull request as ready for review October 27, 2022 11:33
@chfanghr chfanghr changed the base branch from connor/audit-fix to staging October 27, 2022 12:22
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch from 9a63c2a to 35c40a0 Compare October 27, 2022 12:24
lukipuki
lukipuki approved these changes Oct 27, 2022
View reviewed changes
Copy link

@lukipuki lukipuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick pass looks good. We have to re-audit the changes but I'm fine with merging.

Let's wait for @cptmikx's approval.

@chfanghr chfanghr requested a review from lukipuki October 27, 2022 12:43
@lukipuki lukipuki mentioned this pull request Oct 27, 2022
Closed
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch from 35c40a0 to c50fe86 Compare October 27, 2022 13:16
cptmikx
cptmikx approved these changes Oct 28, 2022
View reviewed changes
Copy link

@cptmikx cptmikx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the issues are resolved, gj!

@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch from c50fe86 to 5388cd2 Compare October 28, 2022 10:50
@chfanghr chfanghr mentioned this pull request Oct 28, 2022
Merged
@chfanghr chfanghr force-pushed the connor/audit-fix-proposal branch from 5388cd2 to 97336d5 Compare October 28, 2022 15:58
emiflake
emiflake approved these changes Oct 28, 2022
View reviewed changes
@emiflake emiflake merged commit db569f4 into staging Oct 28, 2022
@chfanghr chfanghr mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake approved these changes

@cptmikx cptmikx cptmikx approved these changes

@lukipuki lukipuki Awaiting requested review from lukipuki

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chfanghr @lukipuki @emiflake @cptmikx