Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SST exploit #203

Merged
merged 7 commits into from
Oct 31, 2022
Merged

Fix SST exploit #203

merged 7 commits into from
Oct 31, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Oct 28, 2022 •
edited
Loading

Based on #200 and #202

@chfanghr chfanghr force-pushed the connor/fix-state-token-exploit branch from f009b21 to c99ceb4 Compare October 28, 2022 13:26
@chfanghr chfanghr requested a review from emiflake October 28, 2022 13:27
emiflake
emiflake approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the diff. Code looks fine after it's rebased.

We should probably also just merge this one, and close #202.

@chfanghr
Copy link
Contributor Author

Yeah, that makes sense.

@chfanghr chfanghr force-pushed the connor/fix-state-token-exploit branch from c99ceb4 to 01cc883 Compare October 28, 2022 23:51
colll78 and others added 2 commits October 29, 2022 07:57
@colll78 @chfanghr
disallow minting new GATs while burning
323b2db 
Co-authored-by: Hongrui Fang <chfanghr@gmail.com>
@colll78 @chfanghr
update benchmark
1adb668 
Co-authored-by: Hongrui Fang <chfanghr@gmail.com>
@chfanghr chfanghr force-pushed the connor/fix-state-token-exploit branch from 01cc883 to 0798274 Compare October 29, 2022 00:04
@chfanghr chfanghr marked this pull request as ready for review October 29, 2022 00:05
@chfanghr chfanghr enabled auto-merge October 29, 2022 00:05
@chfanghr chfanghr disabled auto-merge October 29, 2022 00:05
@chfanghr chfanghr enabled auto-merge October 29, 2022 00:05
@chfanghr chfanghr mentioned this pull request Oct 29, 2022
Closed
@colll78 @chfanghr
update changelog
b9bca9d 
Co-authored-by: Hongrui Fang <chfanghr@gmail.com>
@chfanghr chfanghr force-pushed the connor/fix-state-token-exploit branch from 0798274 to 2bc03b8 Compare October 29, 2022 00:13
lukipuki
lukipuki reviewed Oct 31, 2022
View reviewed changes
cptmikx
cptmikx approved these changes Oct 31, 2022
View reviewed changes
Copy link

@cptmikx cptmikx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff looks good!

@chfanghr chfanghr force-pushed the connor/fix-state-token-exploit branch from 2bc03b8 to a721504 Compare October 31, 2022 10:11
@chfanghr
Copy link
Contributor Author

CI refused to pick it up, but why?

@chfanghr chfanghr mentioned this pull request Oct 31, 2022
Merged
@emiflake
Copy link
Member

CI refused to pick it up, but why?

Hydra is still a mystery... It builds locally though, so imo it's good to go.

@emiflake emiflake disabled auto-merge October 31, 2022 11:33
@emiflake emiflake merged commit 020693e into staging Oct 31, 2022
@chfanghr chfanghr mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukipuki lukipuki lukipuki approved these changes

@emiflake emiflake emiflake approved these changes

@cptmikx cptmikx cptmikx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chfanghr @emiflake @lukipuki @cptmikx @colll78