Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address more issues raised by auditors #208

Merged
merged 15 commits into from
Nov 21, 2022
Merged

Address more issues raised by auditors #208

merged 15 commits into from
Nov 21, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Nov 4, 2022

Based on #207

@chfanghr chfanghr requested a review from emiflake November 4, 2022 16:09
@chfanghr chfanghr force-pushed the connor/audit-fix branch 2 times, most recently from d1b8033 to b725353 Compare November 7, 2022 07:03
@emiflake emiflake changed the title Address more issues raise by auditos Address more issues raise by auditors Nov 7, 2022
emiflake
emiflake requested changes Nov 7, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Just found a typo.

@emiflake emiflake changed the title Address more issues raise by auditors Address more issues raised by auditors Nov 7, 2022
emiflake
emiflake approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now.

@chfanghr chfanghr force-pushed the connor/audit-fix branch 3 times, most recently from 4070f2b to b99514d Compare November 10, 2022 11:14
@chfanghr chfanghr mentioned this pull request Nov 11, 2022
Merged
@chfanghr chfanghr force-pushed the connor/bump-lpe branch 3 times, most recently from be59fc7 to af17e46 Compare November 11, 2022 15:39
@chfanghr chfanghr force-pushed the connor/audit-fix branch 2 times, most recently from 2584a97 to 1524b45 Compare November 11, 2022 16:04
@chfanghr chfanghr mentioned this pull request Nov 14, 2022
Merged
@chfanghr chfanghr force-pushed the connor/audit-fix branch 2 times, most recently from a6df523 to 1b0dfeb Compare November 14, 2022 15:41
@chfanghr chfanghr marked this pull request as ready for review November 15, 2022 15:15
@chfanghr chfanghr changed the base branch from connor/bump-lpe to staging November 15, 2022 15:15
@chfanghr chfanghr requested review from peter-mlabs and removed request for lukipuki November 15, 2022 15:16
emiflake
emiflake requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor documentation things. I'm happy with the changes otherwise!

@chfanghr chfanghr merged commit fadd6ca into staging Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeungheonOh SeungheonOh SeungheonOh left review comments

@lukipuki lukipuki lukipuki approved these changes

@emiflake emiflake emiflake approved these changes

@peter-mlabs peter-mlabs Awaiting requested review from peter-mlabs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chfanghr @lukipuki @emiflake @SeungheonOh