Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate potential DDoS attack(voting and unlocking repeatedly) #209

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Nov 11, 2022

Based on #208

@chfanghr chfanghr requested a review from emiflake November 11, 2022 14:02
@chfanghr chfanghr force-pushed the connor/stake-op-cooldown branch 2 times, most recently from 5be6f54 to f6faaac Compare November 11, 2022 14:35
@chfanghr chfanghr force-pushed the connor/audit-fix branch 2 times, most recently from 2584a97 to 1524b45 Compare November 11, 2022 16:04
@chfanghr chfanghr force-pushed the connor/stake-op-cooldown branch from f6faaac to 7690ae1 Compare November 11, 2022 16:06
@chfanghr chfanghr force-pushed the connor/stake-op-cooldown branch 3 times, most recently from 965401f to c968802 Compare November 14, 2022 09:28
Copy link

@cptmikx cptmikx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments

@chfanghr chfanghr force-pushed the connor/stake-op-cooldown branch 6 times, most recently from 5d5109d to 3961697 Compare November 14, 2022 14:00
@chfanghr chfanghr force-pushed the connor/audit-fix branch 2 times, most recently from a6df523 to 1b0dfeb Compare November 14, 2022 15:41
@chfanghr chfanghr force-pushed the connor/stake-op-cooldown branch 2 times, most recently from faa5bc2 to 9643533 Compare November 14, 2022 15:48
@chfanghr chfanghr force-pushed the connor/audit-fix branch 2 times, most recently from e883f36 to 01d0efc Compare November 16, 2022 04:40
@chfanghr chfanghr changed the base branch from connor/audit-fix to staging November 21, 2022 10:00
@chfanghr chfanghr force-pushed the connor/stake-op-cooldown branch from 9643533 to 2dc08f8 Compare November 21, 2022 10:06
@chfanghr chfanghr marked this pull request as ready for review November 21, 2022 10:06
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks great. Found some docstring issues.

Co-authored-by: Emily Martins <emi@haskell.fyi>
@chfanghr chfanghr enabled auto-merge November 22, 2022 11:40
@chfanghr chfanghr merged commit 462a757 into staging Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants