Add layer id to structural data using a spatial join #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug where structure data points were not being assigned to a unit. Uses a spatial join to assign points
Making column name clearer
RoyThomsonMonash
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Combined with Issue #39 the map_data structure would be set in the init function rather than sample or call but for the moment it works.
I know it isn't a blocker considering Issue #39 but normally I would add a change request to add the map_data argument back into the comment block for the function so documentation is consistent with the function definition.
noellehmcheng
pushed a commit
that referenced
this pull request
May 29, 2025
* fix: adding layerid to structural data bug where structure data points were not being assigned to a unit. Uses a spatial join to assign points * style: style fixes by ruff and autoformatting by black * fix: adding layerID to structure_samples Making column name clearer * update sp join with new index * style: style fixes by ruff and autoformatting by black --------- Co-authored-by: AngRodrigues <126531163+ARodrPGN@users.noreply.github.com> Co-authored-by: AngRodrigues <AngRodrigues@users.noreply.github.com> Co-authored-by: AngRodrigues <afonsoangelarodrigues@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.