Skip to content

Conversation

thebookins
Copy link
Contributor

This PR

  • Merges recent changes to master back to dev
  • Updates Example app to swift 4 and fixes some CocoaPods bugs
  • Changes auth procedure to use write then read, rather that write and notify. This is in line with xDrip+ and xdrip-js. Notifications do not appear to work for the auth characteristic, perhaps as a result of a firmware change.

Should address #65, #55 and #49.

To test

  • run pod install from Example directory
  • open Example/xDripG5.xcworkspace
  • select a provisioning profile, connect iOS device and build

@ps2
Copy link
Contributor

ps2 commented Feb 15, 2018

Thanks. Most of this has been addressed in #67. In the future, please submit any independent changes as separate PRs, and we can tackle them individually.

@ps2 ps2 closed this Feb 15, 2018
@thebookins
Copy link
Contributor Author

thebookins commented Feb 15, 2018

Thanks. I'll try out dev with #67 and submit any further changes separately.

@thebookins thebookins deleted the standalone branch August 24, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants