fix issue with central manager on transmitter ID change #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest changes to dev create a new Transmitter object whenever the transmitter ID is set. However, when the ID is changed in the example app, I have found that the central manager state is
.unsupportedondidUpdateStateand the app does not scan for BLE devices (on iOS 11.2.5). On the next ID change the central manager state is.poweredOn, as expected.As suggested by @ps2, this change removes the call to
disconnect()on deinit (and removes deinit; it doesn't do anything). With this change the central manager does not enter the.unsupportedstate and the app reliably scans on changes to ID.