[Protocol3] Misc small improvements + More tests #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/loopring_v3/contracts/test/Operator.sol # packages/loopring_v3/test/testExchangeBlocks.ts # packages/loopring_v3/test/testExchangeUtil.ts # packages/loopring_v3/test/testExchangeWithdrawalMode.ts
# Conflicts: # packages/loopring_v3/package.json
# Conflicts: # packages/loopring_v3/test/testExchangeCancel.ts # packages/loopring_v3/test/testExchangeUtil.ts # packages/loopring_v3/test/types.ts
…cols into misc-improvements
dong77
requested changes
Jun 29, 2019
|
LGTM
… On Jun 29, 2019, at 09:21, Brecht Devos ***@***.***> wrote:
@Brechtpd <https://github.com/Brechtpd> requested your review on: #241 <#241> [Protocol3] Misc small improvements + More tests.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#241?email_source=notifications&email_token=AANBQB5WKN6UPFC3Y4CLZ7TP422JHA5CNFSM4H4HHX5KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSH2ANYA#event-2448688864>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANBQBYPXLV75Q7SG2D6SILP422JHANCNFSM4H4HHX5A>.
|
dong77
approved these changes
Jul 2, 2019
ghost
pushed a commit
that referenced
this pull request
Jul 3, 2019
* [Protocol3] WIP: maintenance mode changes * [Protocol3] WIP: maintenance mode improvements * [Protocol3] Fixed issue * [Protocol3] Improved docs * [Protocol3] Fixed doc * Update ExchangeMode.sol * Update ExchangeAdmins.sol * [Protocol3] Tests + fixes for improved maintenance mode * [Protocol3] Fixed misc tests * [Protocol3] Added block version * [Protocol3] Added support for data compression * [Protocol3] Removed protocol2-js dependency * [Protocol3] Fixed misc tests * [Protocol3] Renamed numElements to blockSize for consistency * [Protocol3] Optimized onchain decompression * [Protocol3] Improved LZ compressor + ring data transformation * [Protocol3] Misc small improvements * [Protocol3] Improved LZ compressor performance * [Protocol3] Fixed offchain withdrawal message signing * [Protocol3] Update ABI * [Protocol3] Updated generate_keys script for parameter rename * [Protocol3] Break long lines * [Protocol3] Misc small improvements + added misc tests * [Protocol3] Misc improvements/tests for same accounts in requests * [Protocol3] Fixed test * [Protocol3] Added reentrancy tests * [Protocol3] Small refactor * [Protocol3] Added misc ring settlement/block fee tests * [Protocol3] Removed 'only' from tests * [Protocol3] Added transfer tests * [Protocol3] Fixed testing check * [Protocol3] Small refactor (burn -> protocol fees) * [Protocol3] Cleaned up logging * [Protocol3] Fixed precission error in test check * [Protocol3] Added some more misc tests * [Protocol3] Fixed test check for shutdown mode * [Protocol3] Update backend doc * [Protocol3] Small refactoring * [Protocol3] Allow withdrawing the protocol fees directly to pfm * [Protocol3] Changed createOrUpdateAccount to update the Merkle tree * [Protocol3] Fixed compile warning * [Protocol3] Fixed test with AccountContract
ghost
pushed a commit
that referenced
this pull request
Jul 8, 2019
* m * m * modify proto structure * modify git ignore top level * modify git ignore * add test * fix bug && modify * temp commit * Add tslint-microsoft-contrib to devDependencies * Change the version to 0.0.1 * Add index.js to enable import * success access server * Fix merge conflicts in previours PR (#239) * small modify * [Protocol3] remove our own reputation token (#242) * [Protocol3] Misc small improvements + More tests (#241) * [Protocol3] WIP: maintenance mode changes * [Protocol3] WIP: maintenance mode improvements * [Protocol3] Fixed issue * [Protocol3] Improved docs * [Protocol3] Fixed doc * Update ExchangeMode.sol * Update ExchangeAdmins.sol * [Protocol3] Tests + fixes for improved maintenance mode * [Protocol3] Fixed misc tests * [Protocol3] Added block version * [Protocol3] Added support for data compression * [Protocol3] Removed protocol2-js dependency * [Protocol3] Fixed misc tests * [Protocol3] Renamed numElements to blockSize for consistency * [Protocol3] Optimized onchain decompression * [Protocol3] Improved LZ compressor + ring data transformation * [Protocol3] Misc small improvements * [Protocol3] Improved LZ compressor performance * [Protocol3] Fixed offchain withdrawal message signing * [Protocol3] Update ABI * [Protocol3] Updated generate_keys script for parameter rename * [Protocol3] Break long lines * [Protocol3] Misc small improvements + added misc tests * [Protocol3] Misc improvements/tests for same accounts in requests * [Protocol3] Fixed test * [Protocol3] Added reentrancy tests * [Protocol3] Small refactor * [Protocol3] Added misc ring settlement/block fee tests * [Protocol3] Removed 'only' from tests * [Protocol3] Added transfer tests * [Protocol3] Fixed testing check * [Protocol3] Small refactor (burn -> protocol fees) * [Protocol3] Cleaned up logging * [Protocol3] Fixed precission error in test check * [Protocol3] Added some more misc tests * [Protocol3] Fixed test check for shutdown mode * [Protocol3] Update backend doc * [Protocol3] Small refactoring * [Protocol3] Allow withdrawing the protocol fees directly to pfm * [Protocol3] Changed createOrUpdateAccount to update the Merkle tree * [Protocol3] Fixed compile warning * [Protocol3] Fixed test with AccountContract * [Lightcone_V2.js] Make lightcone_v2.js to be imported in react web app (#243) * Point DexService to aws hosted service * Make lightcone_v2.js to import in react web app * Update grpcClient.ts * [Lightcone_V2.js] Migrate Lightcone v2 Javascript to Typescript (#244) * Migrate lightcone v2 js to typescript (Step 1) * Solve typesript errors in walletAccount.ts * Resolve all errors during migration from Javascript to Typescript. * Move tests to typescript in lightcone_v2.js * Add resolveJsonModule to true. Update index.js which is the entrypoint of the package. * Add GetNextOrderIdReq to test importing grpc . Reenable test/grpc.ts * Update grpcClient * fix migrate error by upgrading ganache-cli version (#249) * [Protocol3] rename ProtocolFeeManager to ProtocolFeeVault (#250) * [Protocol3] update ABI files (#251) * modify add grpc-web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.